From: Keir Fraser <keir@xen.org>
To: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] nestedhvm: ASID emulation (cleanup)
Date: Wed, 13 Apr 2011 14:28:40 +0100 [thread overview]
Message-ID: <C9CB6398.2CA33%keir@xen.org> (raw)
In-Reply-To: <201104131520.23648.Christoph.Egger@amd.com>
On 13/04/2011 14:20, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote:
>> On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>>> Cleanup for ASID emulation:
>>> - Use C99 integer types for asid numbers
>>>
>>> - asid.c: consistently use 'v' instead of 'curr'
>>
>> On what planet is that an improvement??
>>
>> We use 'curr' as a convenient idiom to represent cached current. Whereas
>> 'v' is supposed to represent an arbitrary vcpu.
>
> Oh, that's the difference. I thought 'curr' is just another random name for an
> arbitrary vcpu.
>
> I will resend the patch w/o that hunk.
I already applied the two cleanups that I didn't mind, as two separate
changesets. And I've nacked your main patch so you can go take a look at
that. :-)
-- Keir
>>
>> I know it costs three extra characters per use, but it does make code
>> easier to understand.
>>
>> -- Keir
>>
>>> - Introduce svm_invlpga() used in ASID emulation patch
>>>
>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
>
next prev parent reply other threads:[~2011-04-13 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 10:35 [PATCH] nestedhvm: ASID emulation (cleanup) Christoph Egger
2011-04-13 13:06 ` Keir Fraser
2011-04-13 13:20 ` Christoph Egger
2011-04-13 13:28 ` Keir Fraser [this message]
2011-04-13 14:27 ` Christoph Egger
2011-04-13 13:49 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9CB6398.2CA33%keir@xen.org \
--to=keir@xen.org \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).