From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] nestedhvm: ASID emulation (cleanup) Date: Wed, 13 Apr 2011 14:28:40 +0100 Message-ID: References: <201104131520.23648.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201104131520.23648.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 13/04/2011 14:20, "Christoph Egger" wrote: > On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote: >> On 13/04/2011 11:35, "Christoph Egger" wrote: >>> Cleanup for ASID emulation: >>> - Use C99 integer types for asid numbers >>> >>> - asid.c: consistently use 'v' instead of 'curr' >> >> On what planet is that an improvement?? >> >> We use 'curr' as a convenient idiom to represent cached current. Whereas >> 'v' is supposed to represent an arbitrary vcpu. > > Oh, that's the difference. I thought 'curr' is just another random name for an > arbitrary vcpu. > > I will resend the patch w/o that hunk. I already applied the two cleanups that I didn't mind, as two separate changesets. And I've nacked your main patch so you can go take a look at that. :-) -- Keir >> >> I know it costs three extra characters per use, but it does make code >> easier to understand. >> >> -- Keir >> >>> - Introduce svm_invlpga() used in ASID emulation patch >>> >>> Signed-off-by: Christoph Egger >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > >