From: Keir Fraser <keir@xen.org>
To: Christoph Egger <Christoph.Egger@amd.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] nestedhvm: xentrace support
Date: Thu, 14 Apr 2011 15:00:39 +0100 [thread overview]
Message-ID: <C9CCBC97.2CA58%keir@xen.org> (raw)
In-Reply-To: <4DA5C290.9060700@amd.com>
On 13/04/2011 16:34, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>
> Tracing facility for nested virtualization
>
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
I fixed this, by adding an extra argument to HVMTRACE_ND() -- it wasn't
really valid to make the first argument be an arbitarry C expression, due to
argument concatenation that then went on in the macro body.
I also discarded the change to the VMENTRY record to add the guest EIP.
Firstly, it was incomplete, because it did not handle 64-bit RIP. Secondly,
it does not logically belong in this patch. Finally, George may have a
reason for not including RIP in VMENTRY records (e.g., not that useful
compared with the extra space taken up in trace records). So you'd need to
submit a new patch and get an Ack from George (who is currently on holiday).
-- Keir
next prev parent reply other threads:[~2011-04-14 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 15:34 [PATCH] nestedhvm: xentrace support Christoph Egger
2011-04-14 14:00 ` Keir Fraser [this message]
2011-04-14 14:36 ` Christoph Egger
2011-04-14 14:49 ` Keir Fraser
2011-04-18 10:22 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9CCBC97.2CA58%keir@xen.org \
--to=keir@xen.org \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).