From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] nestedhvm: xentrace support
Date: Thu, 14 Apr 2011 15:00:39 +0100
Message-ID: <C9CCBC97.2CA58%keir@xen.org>
References: <4DA5C290.9060700@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4DA5C290.9060700@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 13/04/2011 16:34, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> 
> Tracing facility for nested virtualization
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

I fixed this, by adding an extra argument to HVMTRACE_ND() -- it wasn't
really valid to make the first argument be an arbitarry C expression, due to
argument concatenation that then went on in the macro body.

I also discarded the change to the VMENTRY record to add the guest EIP.
Firstly, it was incomplete, because it did not handle 64-bit RIP. Secondly,
it does not logically belong in this patch. Finally, George may have a
reason for not including RIP in VMENTRY records (e.g., not that useful
compared with the extra space taken up in trace records). So you'd need to
submit a new patch and get an Ack from George (who is currently on holiday).

 -- Keir