From: Keir Fraser <keir.xen@gmail.com>
To: Christoph Egger <Christoph.Egger@amd.com>, Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] nestedhvm: ASID emulation
Date: Fri, 15 Apr 2011 10:24:09 +0100 [thread overview]
Message-ID: <C9CDCD49.1663F%keir.xen@gmail.com> (raw)
In-Reply-To: <4DA80B26.7060700@amd.com>
On 15/04/2011 10:08, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>> You didn't notice my subtle error in switching n1 and n2 asid selection in
>> svm_asid_handle_vmrun()? ;-)
>
> Oh, now that you mention it...
Yeah, I fixed it before I checked it in (xen-unstable:23229).
> A l2 smp guest actually boots up. Maybe I need to use more vcpus than I
> have physical cpus to hit that bug.
I think it would have been a source of very subtle quite hard-to-repro bugs.
Not something you'd pick up in a simple does-it-boot smoke test. So a pretty
nasty bug all round!
-- Keir
next prev parent reply other threads:[~2011-04-15 9:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 10:37 [PATCH] nestedhvm: ASID emulation Christoph Egger
2011-04-13 13:27 ` Keir Fraser
2011-04-13 14:26 ` Christoph Egger
2011-04-13 15:05 ` Keir Fraser
2011-04-13 15:19 ` Christoph Egger
2011-04-13 16:22 ` Keir Fraser
2011-04-14 9:26 ` Christoph Egger
2011-04-14 10:28 ` Keir Fraser
2011-04-14 14:01 ` Christoph Egger
2011-04-14 14:43 ` Keir Fraser
2011-04-15 8:20 ` Christoph Egger
2011-04-15 9:05 ` Keir Fraser
2011-04-15 9:08 ` Christoph Egger
2011-04-15 9:24 ` Keir Fraser [this message]
2011-04-15 9:57 ` Christoph Egger
2011-04-15 12:53 ` Keir Fraser
2011-04-15 12:49 ` Christoph Egger
2011-04-15 13:40 ` Christoph Egger
2011-04-13 13:51 ` Christoph Egger
2011-04-13 14:48 ` Christoph Egger
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 8:57 Christoph Egger
2011-04-13 9:18 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9CDCD49.1663F%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Christoph.Egger@amd.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).