From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] nestedhvm: ASID emulation
Date: Fri, 15 Apr 2011 10:24:09 +0100
Message-ID: <C9CDCD49.1663F%keir.xen@gmail.com>
References: <4DA80B26.7060700@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4DA80B26.7060700@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 15/04/2011 10:08, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

>> You didn't notice my subtle error in switching n1 and n2 asid selection in
>> svm_asid_handle_vmrun()? ;-)
> 
> Oh, now that you mention it...

Yeah, I fixed it before I checked it in (xen-unstable:23229).

> A l2 smp guest actually boots up. Maybe I need to use more vcpus than I
> have physical cpus to hit that bug.

I think it would have been a source of very subtle quite hard-to-repro bugs.
Not something you'd pick up in a simple does-it-boot smoke test. So a pretty
nasty bug all round!

 -- Keir