From: Keir Fraser <keir.xen@gmail.com>
To: "Kay, Allen M" <allen.m.kay@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: "Cihula, Joseph" <joseph.cihula@intel.com>,
Jan Beulich <JBeulich@novell.com>
Subject: Re: [PATCH][VTD] force boot to fail if interrupt remapping cannot be enabled when iommu=force
Date: Thu, 28 Apr 2011 18:05:03 +0100 [thread overview]
Message-ID: <C9DF5CCF.16F23%keir.xen@gmail.com> (raw)
In-Reply-To: <987664A83D2D224EAE907B061CE93D5301C51BE9D8@orsmsx505.amr.corp.intel.com>
On 28/04/2011 00:42, "Kay, Allen M" <allen.m.kay@intel.com> wrote:
> Force Xen boot to fail if interrupt remapping fails to enable and the
> following are true: iommu=force is set as xen boot parameter, VT-d engine HW
> is interrupt remapping capable, DMAR_INTR_REMAP bit is set in DMAR flags.
> This forces iommu=force boot instances has interrupt remapping enabled if HW
> and BIOS supports it.
If HW and BIOS support it, why would it fail to be enabled? This doesn't
look like a particularly useful panic() path. If interrupt remapping is so
important, perhaps iommu=force should unconditionally require it, and panic
in its absence regardless of platform features? As it is, this looks like a
panic that is never realistically going to trigger.
-- Keir
> Signed-off-by: Allen Kay <allen.m.kay@intel.com>
next prev parent reply other threads:[~2011-04-28 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 23:42 [PATCH][VTD] force boot to fail if interrupt remapping cannot be enabled when iommu=force Kay, Allen M
2011-04-28 17:05 ` Keir Fraser [this message]
2011-04-28 18:26 ` Joanna Rutkowska
2011-04-28 18:58 ` Cihula, Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9DF5CCF.16F23%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=allen.m.kay@intel.com \
--cc=joseph.cihula@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).