From: Keir Fraser <keir.xen@gmail.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>,
Jan Beulich <JBeulich@novell.com>
Cc: xen-devel@lists.xensource.com, Allen M Kay <allen.m.kay@intel.com>
Subject: Re: [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain arrays with radix trees
Date: Wed, 04 May 2011 20:55:02 +0100 [thread overview]
Message-ID: <C9E76DA6.1740F%keir.xen@gmail.com> (raw)
In-Reply-To: <ae0451ca-f29e-4bed-b594-573dfdd97fd1@default>
On 04/05/2011 17:13, "Dan Magenheimer" <dan.magenheimer@oracle.com> wrote:
> After some offlist discussion, for kztmem (later renamed "the new
> zcache"), I ended up extracting the essence of the radix-tree data
> structure and adapting it inline specifically for my in-kernel tmem
> needs. While I'm not a fan of duplicating code, this was an
> expedient way to avoid a political quagmire.
>
> Ideally, the Xen radix-tree.c would support both needs through some
> kind of layering, but if your preference is to go to the upstream
> Linux radix-tree.c, I can probably leverage my inlined-radix-tree
> code into Xen tmem.c. I don't expect it will be trivial though.
I'm sure I can pull in upstream radix-tree.c and get Xen's tmem ported onto
it. As for performance, I may leave the tagging stuff out as we won't need
it. Then it's just quibbling over RCU overheads, which I would bet are
manageable. We can modify radix-tree.c further if there is good reason for
it.
-- Keir
next prev parent reply other threads:[~2011-05-04 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 14:08 [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain arrays with radix trees Jan Beulich
2011-05-03 21:08 ` Keir Fraser
2011-05-04 7:27 ` Jan Beulich
2011-05-04 8:13 ` Keir Fraser
2011-05-04 16:13 ` Dan Magenheimer
2011-05-04 19:55 ` Keir Fraser [this message]
2011-05-04 20:37 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9E76DA6.1740F%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=allen.m.kay@intel.com \
--cc=dan.magenheimer@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).