xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Jacob Shin <jacob.shin@amd.com>, Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 3/3] hvm: vpmu: Add support for AMD  Family 15h processors
Date: Tue, 10 May 2011 18:20:44 +0100	[thread overview]
Message-ID: <C9EF327C.1A191%keir.xen@gmail.com> (raw)
In-Reply-To: <4DC96F18.7030406@amd.com>

On 10/05/2011 18:00, "Jacob Shin" <jacob.shin@amd.com> wrote:

> On 05/05/2011 02:43 AM, Jan Beulich wrote:
>>>>> On 05.05.11 at 03:09, Jacob Shin<jacob.shin@amd.com>  wrote:
>>> --- a/xen/arch/x86/hvm/vpmu.c Wed May 04 10:56:36 2011 -0500
>>> +++ b/xen/arch/x86/hvm/vpmu.c Wed May 04 19:17:59 2011 -0500
>>> @@ -101,6 +101,7 @@ void vpmu_initialise(struct vcpu *v)
>>>           switch ( family )
>>>           {
>>>           case 0x10:
>>> +        case 0x15:
>>>               vpmu->arch_vpmu_ops =&amd_vpmu_ops;
>>>               break;
>>>           default:
>> 
>> How about 0x11, 0x12, and 0x14?
>> 
> 
> Family 11h does not have guest only event monitoring .. but yes, we can
> enable 12h and 14h in the same path as the 10h. I'll send out a revised
> patchset later this afternoon.

I already applied your patch series (with MSRs renamed as Jan recommended).
So just send the above as a delta patch please.

 -- Keir

> Thanks!
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/x

      reply	other threads:[~2011-05-10 17:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05  0:54 [PATCH 0/3] AMD Family 15h Performance Monitor Counters patches Jacob Shin
2011-05-05  1:09 ` [PATCH 1/3] xenoprof: Update cpu_type to sync with upstream oprofile Jacob Shin
2011-05-05  1:09 ` [PATCH 2/3] xenoprof: Add support for AMD Family 15h processors Jacob Shin
2011-05-05  7:38   ` Jan Beulich
2011-05-05  1:09 ` [PATCH 3/3] hvm: vpmu: " Jacob Shin
2011-05-05  7:43   ` Jan Beulich
2011-05-10 17:00     ` Jacob Shin
2011-05-10 17:20       ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C9EF327C.1A191%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=JBeulich@novell.com \
    --cc=jacob.shin@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).