From: Keir Fraser <keir@xen.org>
To: "Liu, Jinsong" <jinsong.liu@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: "Jiang, Yunhong" <yunhong.jiang@intel.com>,
"Dong, Eddie" <eddie.dong@intel.com>,
"Li, Xin" <xin.li@intel.com>
Subject: Re: [PATCH] X86: Fix a little mca bug
Date: Fri, 20 May 2011 09:10:18 +0100 [thread overview]
Message-ID: <C9FBE07A.2D7D6%keir@xen.org> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E2083B2EDEA@shsmsx502.ccr.corp.intel.com>
On 19/05/2011 13:03, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:
> X86: Fix a little mca bug
>
> At x86_mcinfo_dump(), a little bug at printk information, illusively
> indicate an CMCI/POLLED error to a MCE error, this will make debug confusing.
Is it correct to have entirely removed the final else clause?
-- Keir
> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>
>
> diff -r 2fe45768d2c1 xen/arch/x86/cpu/mcheck/mce.c
> --- a/xen/arch/x86/cpu/mcheck/mce.c Tue May 10 13:58:21 2011 +0800
> +++ b/xen/arch/x86/cpu/mcheck/mce.c Thu May 19 15:10:07 2011 +0800
> @@ -944,10 +944,11 @@ void x86_mcinfo_dump(struct mc_info *mi)
> printk(XENLOG_WARNING
> "CPU%d: Machine Check Exception: %16"PRIx64"\n",
> mc_global->mc_coreid, mc_global->mc_gstatus);
> - } else {
> - printk(XENLOG_WARNING "MCE: The hardware reports a non "
> - "fatal, correctable incident occurred on "
> - "CPU %d.\n",
> + } else if (mc_global->mc_flags & MC_FLAG_CMCI) {
> + printk(XENLOG_WARNING "CMCI occurred on CPU %d.\n",
> + mc_global->mc_coreid);
> + } else if (mc_global->mc_flags & MC_FLAG_POLLED) {
> + printk(XENLOG_WARNING "POLLED occurred on CPU %d.\n",
> mc_global->mc_coreid);
> }
>
next prev parent reply other threads:[~2011-05-20 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 12:03 [PATCH] X86: Fix a little mca bug Liu, Jinsong
2011-05-20 8:10 ` Keir Fraser [this message]
2011-05-20 11:50 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9FBE07A.2D7D6%keir@xen.org \
--to=keir@xen.org \
--cc=eddie.dong@intel.com \
--cc=jinsong.liu@intel.com \
--cc=xen-devel@lists.xensource.com \
--cc=xin.li@intel.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).