From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 0 of 4] xentrace [v2]: non-contiguous allocation of per-cpu buffer Date: Fri, 20 May 2011 09:36:30 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Olaf Hering , xen-devel@lists.xensource.com Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org On 10/05/2011 15:32, "Olaf Hering" wrote: > This series implements non-contiguous trace buffers. I haven't seen an Ack for these yet. -- Keir > There was an overflow in the offset calculation because it was stored in > an int. Also the calculation of the per-cpu buffer did not take the type > of the offset value into account. This was the reason why I ran into the > checks in bogus(). The crash in out_dealloc: was caused by the lack of > check for the offset value. > > Regarding the math added to next_record() another array of pointers could be > added to remove the mfn_to_virt() calls. In my testing 9343 trace pages on 8 > cpus are used. Such an array would required additional (9343*8*8)/1024=583Kb. > Which is not too much, given the amount of 291MB tracebuffers. > Such a change is not part of this series. > > Olaf > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel