From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 29 of 45] gcc-4.6 compile fix: xen/arch/x86/cpu/intel.c Date: Fri, 20 May 2011 09:38:50 +0100 Message-ID: References: <4DD63A9E0200007800042615@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4DD63A9E0200007800042615@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Olaf Hering Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 20/05/2011 08:55, "Jan Beulich" wrote: >> intel.c: In function 'set_cpuidmask': >> intel.c:36:14: error: variable 'extra' set but not used >> [-Werror=unused-but-set-variable] > > No, please don't push this - it was a mistake that "extra" wasn't > used, and > http://lists.xensource.com/archives/html/xen-devel/2011-05/msg00753.html > corrects this. Ha, too late, that was one of the patches I cherry picked as a reasonable cleanup. Your patch will have to reintroduce "extra". -- Keir