xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xen.org>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Olaf Hering <olaf@aepfle.de>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [xen-4.0-testing test] 7147: regressions - FAIL
Date: Mon, 23 May 2011 16:49:31 +0100	[thread overview]
Message-ID: <CA00409B.2D9AF%keir@xen.org> (raw)
In-Reply-To: <19930.32778.342171.90825@mariner.uk.xensource.com>

On 23/05/2011 16:40, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

> Keir Fraser writes ("Re: [Xen-devel] [xen-4.0-testing test] 7147: regressions
> - FAIL"):
>> Here's a nice short one that seems to work for me. It does rely on the
>> compiler emitting the word 'unrecognized' iff the option under test is
>> unrecognised. I strongly suspect this is a safe bet.
> 
> Sadly, some mad people run with LC_MESSAGES set to something other
> than C which produces native-language error messages even from gcc.

Well LC_ALL=C is easy to add.

>> Unfortunately I can't
>> see any way around grepping the output, since otherwise we can't distinguish
>> the integer-assignment-to-pointer warning from the unrecognised-option
>> warning.
> 
> We don't need to distinguish them.  We just need to know whether
> passing the option works or not.  That's what my patch does.

Ahhh... Is this because of a emitted-as-an-error-not-a-warning bug in Debian
gcc, on top of the more general lazily-detected-unrecognised-Wno-option
behaviour?

Well, tbh I'd rather get rid of unsupported -Wno- options in general, not
just where they are erroneously emitted as errors. Otherwise it will confuse
everyone that each time they get a compile warning they also get extra bogus
unrecognised option messages. That would be pretty crappy.

 -- Keir

> Ian.

  reply	other threads:[~2011-05-23 15:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21 21:34 [xen-4.0-testing test] 7147: regressions - FAIL xen.org
2011-05-21 22:19 ` Keir Fraser
2011-05-23 11:10   ` Olaf Hering
2011-05-23 12:32   ` Ian Campbell
2011-05-23 14:06     ` Ian Jackson
2011-05-23 15:08       ` Ian Jackson
2011-05-23 15:14         ` Ian Campbell
2011-05-23 15:18           ` Ian Jackson
2011-05-23 15:24         ` Keir Fraser
2011-05-23 15:33           ` Ian Jackson
2011-05-23 15:37           ` Keir Fraser
2011-05-23 15:40             ` Ian Jackson
2011-05-23 15:49               ` Keir Fraser [this message]
2011-05-23 16:16                 ` Keir Fraser
2011-05-23 12:59   ` Olaf Hering
  -- strict thread matches above, loose matches on Subject: below --
2011-05-22 16:29 M A Young
2011-05-22 18:10 ` [xen-4.0-testing " Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA00409B.2D9AF%keir@xen.org \
    --to=keir@xen.org \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).