From: Keir Fraser <keir@xen.org>
To: Tim Deegan <Tim.Deegan@citrix.com>, Wei Liu <liuw@liuw.name>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH 1/2] Xen: enabling emulated MSI injection
Date: Thu, 26 May 2011 10:10:51 +0100 [thread overview]
Message-ID: <CA03D7AB.2DAB8%keir@xen.org> (raw)
In-Reply-To: <20110526084331.GB9790@whitby.uk.xensource.com>
On 26/05/2011 09:43, "Tim Deegan" <Tim.Deegan@citrix.com> wrote:
>> +/* MSI injection for emulated devices */
>> +#define HVMOP_inj_msi 16
>> +struct xen_hvm_inj_msi {
>> + /* Domain to be injected */
>> + domid_t domid;
>> + /* Address (0xfeeXXXXX) */
>> + uint64_t addr;
>> + /* Data -- lower 32 bits */
>> + uint32_t data;
>> +};
>
> Please rearrange this so that it has the same size and layout on 32-bit
> and 64-bit builds.
You can do this most easily be simply swapping the second and third fields.
-- Keir
next prev parent reply other threads:[~2011-05-26 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 3:08 [PATCH 1/2] Xen: enabling emulated MSI injection Wei Liu
2011-05-26 3:21 ` Tian, Kevin
2011-05-26 3:30 ` Wei Liu
2011-05-26 5:26 ` Tian, Kevin
2011-05-26 5:43 ` Wei Liu
2011-05-26 6:31 ` Wei Liu
2011-05-26 8:43 ` Tim Deegan
2011-05-26 9:10 ` Keir Fraser [this message]
2011-05-26 11:25 ` Stefano Stabellini
2011-05-26 11:49 ` Keir Fraser
2011-05-26 12:51 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA03D7AB.2DAB8%keir@xen.org \
--to=keir@xen.org \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=Tim.Deegan@citrix.com \
--cc=kevin.tian@intel.com \
--cc=liuw@liuw.name \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).