From: Keir Fraser <keir.xen@gmail.com>
To: Tim Deegan <Tim.Deegan@citrix.com>, Eddie Dong <eddie.dong@intel.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 20 of 20] n2 MSR handling and capability exposure
Date: Thu, 02 Jun 2011 20:20:06 +0100 [thread overview]
Message-ID: <CA0DA0F6.1B844%keir.xen@gmail.com> (raw)
In-Reply-To: <20110602151128.GQ5098@whitby.uk.xensource.com>
On 02/06/2011 16:11, "Tim Deegan" <Tim.Deegan@citrix.com> wrote:
>> BTW, I don't really like defining all these REMOVED_* macros, each
>> of which is used only once a few lines from the definition (here and
>> elsewhere in the series). It just adds clutter for no benefit.
>>
>
> Oh, I forgot to say: will this feature-blacklisting work over live
> migration to a machine with a different CPU? There isn't an equivalnet
> of the CPUID masking feature to make all the machines in a cluster seem
> to have the same VMX features.
>
> Elsewhere we use whitelisting for passsing hardware capability flags to
> HVM guests; I think we should use whitelists here too.
Blacklists create a total mess of doom. We should absolutely disallow the
creation of any new ones. I think HVM guests are currently clean in this
regard and should stay that way.
-- Keir
next prev parent reply other threads:[~2011-06-02 19:20 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 8:57 [PATCH 00 of 20] NestedVMX support Eddie Dong
2011-06-02 8:57 ` [PATCH 01 of 20] pre-cleanup1: Extend nhvm_vmcx_guest_intercepts_trap to include errcode to Eddie Dong
2011-06-02 8:57 ` [PATCH 02 of 20] pre-cleanup2: Move IDT_VECTORING processing code out of intr_assist Eddie Dong
2011-06-02 8:57 ` [PATCH 03 of 20] Add data structure for nestedvmx Eddie Dong
2011-06-02 8:57 ` [PATCH 04 of 20] Add APIs for nestedhvm_ops Eddie Dong
2011-06-02 8:57 ` [PATCH 05 of 20] Emulation of guest VMXON/OFF instruction Eddie Dong
2011-06-02 14:36 ` Tim Deegan
2011-06-03 5:54 ` Dong, Eddie
2011-06-02 8:57 ` [PATCH 06 of 20] Define structure and access APIs for virtual VMCS Eddie Dong
2011-06-02 8:57 ` [PATCH 07 of 20] Emulation of guest vmptrld Eddie Dong
2011-06-02 14:45 ` Tim Deegan
2011-06-03 6:07 ` Dong, Eddie
2011-06-03 8:42 ` Tim Deegan
2011-06-07 1:48 ` Dong, Eddie
2011-06-02 8:57 ` [PATCH 08 of 20] Emulation of guest VMPTRST Eddie Dong
2011-06-02 8:57 ` [PATCH 09 of 20] Emulation of guest VMCLEAR Eddie Dong
2011-06-02 8:57 ` [PATCH 10 of 20] Emulation of guest VMWRITE Eddie Dong
2011-06-02 8:57 ` [PATCH 11 of 20] Emulation of guest VMREAD Eddie Dong
2011-06-02 8:57 ` [PATCH 12 of 20] Add APIs to switch n1/n2 VMCS Eddie Dong
2011-06-02 14:50 ` Tim Deegan
2011-06-03 7:30 ` Dong, Eddie
2011-06-02 8:57 ` [PATCH 13 of 20] Emulation of VMRESUME/VMLAUNCH Eddie Dong
2011-06-02 8:57 ` [PATCH 14 of 20] Extend VMCS control fields for n2 guest Eddie Dong
2011-06-02 8:57 ` [PATCH 15 of 20] Switch shadow/virtual VMCS between n1/n2 guests Eddie Dong
2011-06-02 14:56 ` Tim Deegan
2011-06-03 7:57 ` Dong, Eddie
2011-06-02 14:58 ` Tim Deegan
2011-06-02 8:57 ` [PATCH 16 of 20] interrupt/exception handling for n2 guest Eddie Dong
2011-06-02 8:57 ` [PATCH 17 of 20] VM exit handler of n2-guest Eddie Dong
2011-06-02 14:59 ` Tim Deegan
2011-06-03 8:06 ` Dong, Eddie
2011-06-03 8:43 ` Tim Deegan
2011-06-02 8:57 ` [PATCH 18 of 20] Lazy FPU for n2 guest Eddie Dong
2011-06-02 8:57 ` [PATCH 19 of 20] Add VMXE bits in virtual CR4 Eddie Dong
2011-06-02 15:01 ` Tim Deegan
2011-06-03 8:12 ` Dong, Eddie
2011-06-02 8:57 ` [PATCH 20 of 20] n2 MSR handling and capability exposure Eddie Dong
2011-06-02 15:07 ` Tim Deegan
2011-06-02 15:11 ` Tim Deegan
2011-06-02 19:20 ` Keir Fraser [this message]
2011-06-03 8:39 ` Dong, Eddie
2011-06-03 8:25 ` Dong, Eddie
2011-06-02 14:33 ` [PATCH 00 of 20] NestedVMX support Tim Deegan
2011-06-03 5:47 ` Dong, Eddie
-- strict thread matches above, loose matches on Subject: below --
2011-06-09 8:25 [PATCH 00 of 20] Rebased Nested VMX v2 Eddie Dong
2011-06-09 8:25 ` [PATCH 20 of 20] n2 MSR handling and capability exposure Eddie Dong
2011-06-13 8:27 ` Tim Deegan
2011-06-14 2:29 ` Dong, Eddie
2011-06-15 12:45 ` Tim Deegan
2011-06-20 6:31 ` Jeroen Groenewegen van der Weyden
2011-06-30 14:14 ` Jeroen Groenewegen van der Weyden
2011-07-01 9:01 ` Tim Deegan
2011-07-01 9:54 ` Christoph Egger
2011-07-01 10:11 ` Jeroen Groenewegen van der Weyden
2011-07-04 8:58 ` Tim Deegan
2011-07-04 9:58 ` Jeroen Groenewegen van der Weyden
2011-07-08 7:12 ` Jeroen Groenewegen van der Weyden
2011-07-18 15:41 ` Dong, Eddie
2011-07-19 13:59 ` Jeroen Groenewegen van der Weyden
2011-07-20 13:44 ` Dong, Eddie
2011-07-20 14:12 ` Jeroen Groenewegen van der Weyden
2011-07-25 14:08 ` Tim Deegan
2011-07-25 16:16 ` Tim Deegan
2011-07-26 7:15 ` Jeroen Groenewegen van der Weyden
2011-07-26 10:00 ` Tim Deegan
2011-07-26 10:11 ` Tim Deegan
2011-07-26 10:46 ` Jeroen Groenewegen van der Weyden
2011-07-26 11:42 ` Tim Deegan
2011-07-26 13:33 ` Jeroen Groenewegen van der Weyden
2011-07-26 14:21 ` Tim Deegan
2011-07-26 15:25 ` Jeroen Groenewegen van der Weyden
2011-07-26 15:48 ` Tim Deegan
2011-07-26 16:00 ` Jeroen Groenewegen van der Weyden
2011-07-26 16:08 ` Tim Deegan
2011-07-26 11:05 ` Jeroen Groenewegen van der Weyden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA0DA0F6.1B844%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Tim.Deegan@citrix.com \
--cc=eddie.dong@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).