From: Keir Fraser <keir.xen@gmail.com>
To: "Li, Xin" <xin.li@intel.com>, Jan Beulich <JBeulich@novell.com>,
"Yang, Wei Y" <wei.y.yang@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [Patch] Enable SMEP CPU feature support for XEN itself
Date: Fri, 03 Jun 2011 13:34:04 +0100 [thread overview]
Message-ID: <CA0E934C.1B90C%keir.xen@gmail.com> (raw)
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD5AB9EC67@shsmsx501.ccr.corp.intel.com>
On 03/06/2011 12:54, "Li, Xin" <xin.li@intel.com> wrote:
>>> The whole point of setup_clear_cpu_cap() is that it only needs to run on the
>>> BP and the change gets picked up by every AP automatically as it boots.
>>
>> Yeah, and we can't do leaf 7.0 detect in generic_identify. Or will again set
>> SMEP in
>> capabilities, but it should be ok.
>
> I tried to not do leaf 7.0 detect on AP booting code, but system behaves
> abnormally
> (not hang, but "su -" never returns, after just revert the change, it runs
> well).
>
> While at this point I want to focus on SMEP logic, we can make the
> improvements,
> to move such initialization to BP code only, later. Also it makes no much
> sense to only
> move disable_smep that way, we should move all such variables.
Just get another rev of the patches out and we'll iterate if necessary.
-- Keir
> Thanks!
> -Xin
next prev parent reply other threads:[~2011-06-03 12:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 13:29 [Patch] Enable SMEP CPU feature support for XEN itself Jan Beulich
2011-06-02 14:36 ` Li, Xin
2011-06-02 15:05 ` Li, Xin
2011-06-02 19:24 ` Keir Fraser
2011-06-02 22:49 ` Li, Xin
2011-06-03 11:54 ` Li, Xin
2011-06-03 12:34 ` Keir Fraser [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-01 13:20 Yang, Wei Y
2011-06-01 14:34 ` Keir Fraser
2011-06-01 14:50 ` Li, Xin
2011-06-01 15:17 ` Jan Beulich
2011-06-01 15:23 ` Ian Campbell
2011-06-02 4:20 ` Li, Xin
2011-06-02 7:45 ` Li, Xin
2011-06-01 15:26 ` Keir Fraser
2011-06-01 16:15 ` Li, Xin
2011-06-01 20:43 ` Keir Fraser
2011-06-01 22:52 ` Li, Xin
2011-06-02 6:25 ` Keir Fraser
2011-06-02 10:07 ` Li, Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA0E934C.1B90C%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=wei.y.yang@intel.com \
--cc=xen-devel@lists.xensource.com \
--cc=xin.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).