From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: weidong.han@intel.com
Subject: Re: IOMMU Interrupt Remapping query
Date: Mon, 06 Jun 2011 16:21:19 +0100 [thread overview]
Message-ID: <CA12AEFF.1BAA1%keir.xen@gmail.com> (raw)
In-Reply-To: <4DECE4EF.6050506@citrix.com>
On 06/06/2011 15:32, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
> I am attempting to fix the kexec interactions with x2apic and iommu
> functionality. Part of this involves ensuring that all IOMMU
> functionality is disabled, as the kdump kernels are not happy at having
> their interrupts remapped without their knowledge.
>
> I have introduced iommu_disable_x2apic_IR() onto the kexec path, but it
> does not seem to actually disable interrupt remapping on Intel boxes
> (Specifically the two Intel Nehalem boxes I am testing on).
>
> Specifying iommu=no-intremap on the commandline causes everything to
> work correctly, but leaving it out causes the kdump kernel to hang and
> eventually reboot, as can be seen on the attached serial log.
>
> The lines starting DBG: are extra debugging I have put in which shows
> that the disable_IR() function is being called and writing to the registers.
Should have attached your patch as well. Noone else can know with certainty
where you put your debugging, and noone else is going to want to help debug
your code if they can't even see it. :-)
Also a good idea to Cc a likely person who can help (i.e., someone who wrote
the code that you are querying). 'hg annotate' is useful for this -- in this
case I am adding Weidong Han to the cc list.
On the bright side, this must have been got working for S3 suspend/resume to
work properly (indeed that's what the disable code was originally added
for). So it can't be an insurmountable problem.
-- Keir
> This problem occurs with the XenServer version of 4.1.0 as well as on
> xen-unstable at the moment.
>
> Is there any hardware state which is not taken down by the disable
> function, any subtle interactions which I have not taken account of? I
> have looked through the source and nothing pops out, but I am out of ideas.
>
> Thanks in advance,
next prev parent reply other threads:[~2011-06-06 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 14:32 IOMMU Interrupt Remapping query Andrew Cooper
2011-06-06 15:21 ` Keir Fraser [this message]
2011-06-06 16:37 ` Andrew Cooper
2011-06-06 18:45 ` Keir Fraser
2011-06-06 18:53 ` Keir Fraser
2011-06-07 8:44 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA12AEFF.1BAA1%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=weidong.han@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).