From: Keir Fraser <keir@xen.org>
To: "John McDermott (U.S. Navy Employee)"
<john.mcdermott@nrl.navy.mil>,
xen-devel@lists.xensource.com
Subject: Re: Bug in smpboot.c?
Date: Fri, 10 Jun 2011 08:30:10 +0100 [thread overview]
Message-ID: <CA178692.2E741%keir@xen.org> (raw)
In-Reply-To: <FF7C94F8-BCD0-4B8F-8574-201BAF6C3FA2@nrl.navy.mil>
On 09/06/2011 16:49, "John McDermott (U.S. Navy Employee)"
<john.mcdermott@nrl.navy.mil> wrote:
> Xen Developers,
>
> In C function cpu_add(), in xen/arch/x86/smpboot.c, if acpi_id ==
> MAX_MADT_ENTRIES, won't this write past the end of array
> x86_acpiid_toapicid[MAX_MADT_ENTRIES]? I am looking at xen-unstable. It looks
> like the guard is not catching this 1 case?
Fixed in xen-unstable:23505. Fortunately this function is only accessible
from the TCB so it's not exploitable.
Thanks,
-- Keir
> Sincerely,
>
> John McDermott
> ----
> What is the formal meaning of the one-line program
> #include "/dev/tty"
>
> J.P. McDermott building 12
> Code 5542 mcdermott@itd.nrl.navy.mil
> Naval Research Laboratory voice: +1 202.404.8301
> Washington, DC 20375, US fax: +1 202.404.7942
>
>
>
>
>
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-06-10 7:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 15:49 Bug in smpboot.c? John McDermott (U.S. Navy Employee)
2011-06-09 22:09 ` Keir Fraser
2011-06-10 5:36 ` Addback capability check for non-initial features Dong, Eddie
2011-06-10 5:50 ` Dong, Eddie
2011-06-10 6:05 ` Keir Fraser
2011-06-10 6:33 ` Dong, Eddie
2011-06-10 6:58 ` Keir Fraser
2011-06-10 7:33 ` Keir Fraser
2011-06-10 8:05 ` Dong, Eddie
2011-06-10 7:30 ` Keir Fraser [this message]
2011-06-10 11:31 ` Bug in smpboot.c? John McDermott CIV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA178692.2E741%keir@xen.org \
--to=keir@xen.org \
--cc=john.mcdermott@nrl.navy.mil \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).