From: Keir Fraser <keir@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] IRQ: manually EOI migrating line interrupts
Date: Tue, 30 Aug 2011 15:38:53 +0100 [thread overview]
Message-ID: <CA82B48D.30D07%keir@xen.org> (raw)
In-Reply-To: <4E5CF393.10903@citrix.com>
On 30/08/2011 15:28, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
>> @@ -1739,6 +1739,14 @@ static void end_level_ioapic_irq (unsign
>> */
>> i = IO_APIC_VECTOR(irq);
>>
>> + /* Manually EOI the old vector if we are moving to the new */
>> + if ( vector && i != vector )
>> + {
>> + int ioapic;
>> + for (ioapic = 0; ioapic < nr_ioapics; ioapic++)
>> + io_apic_eoi(ioapic, i);
>> + }
>> +
I don't know whether it's worth the effort, but we ought to be able to do
better than this and send EOI to exactly the correct IO-APIC. I think
irq=gsi here? And we should know the gsi_base of every IO-APIC, so we can
work out in fact which pin of which IO-APIC needs clobbering?
-- Keir
next prev parent reply other threads:[~2011-08-30 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 14:17 [PATCH] IRQ: manually EOI migrating line interrupts Andrew Cooper
2011-08-30 14:19 ` Andrew Cooper
2011-08-30 14:28 ` Andrew Cooper
2011-08-30 14:35 ` Keir Fraser
2011-08-30 15:03 ` Andrew Cooper
2011-08-30 14:38 ` Keir Fraser [this message]
2011-08-30 15:19 ` Andrew Cooper
2011-08-30 16:04 ` Keir Fraser
2011-09-05 10:50 ` Jan Beulich
2011-09-05 12:24 ` Andrew Cooper
2011-09-05 10:43 ` Jan Beulich
2011-09-05 12:29 ` Andrew Cooper
2011-09-05 12:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA82B48D.30D07%keir@xen.org \
--to=keir@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).