xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Marek Marczykowski <marmarek@mimuw.edu.pl>,
	Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: xen-devel@lists.xensource.com,
	Joanna Rutkowska <joanna@invisiblethingslab.com>,
	Rafal Wojtczuk <rafal@invisiblethingslab.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: xen-4.1: PV domain hanging at startup, jiffies stopped
Date: Wed, 31 Aug 2011 22:01:52 +0100	[thread overview]
Message-ID: <CA845FD0.2013E%keir.xen@gmail.com> (raw)
In-Reply-To: <4E5E9E69.7000600@mimuw.edu.pl>

On 31/08/2011 21:49, "Marek Marczykowski" <marmarek@mimuw.edu.pl> wrote:

> xen_vcpuop_set_next_event schedules event by getting current time
> (xen_clocksource_read()) (*1) adding delta (expires-now) and programming
> event with VCPUOP_set_singleshot_timer hypercall. Then xen gets current
> time (*2) and in some rare cases this time is after expected timer
> expiration... Even after VCPUOP_set_singleshot_timer hypercal,
> xen_clocksource_read() reports time slightly in the past comparing to
> xen time (reported by NOW() macro).
> 
> I think this is because "current" time is calculated different way in *1
> and *2. The *1 way is controlled by tsc_mode, which is described here:
> http://lxr.xensource.com/lxr/source/docs/misc/tscmode.txt. Default
> tsc_mode=0 is "smart" and I think because of that can be slightly before
> NOW() time. tsc_mode=2 looks almost the same as NOW() macro works.
> 
> Is this reasoning correct?

They really ought to work out to the same thing. This will trivially be the
case with tsc_mode=2 because both guest and hypervisor will see the same
(real) values from RDTSC, and use the same offsets and sacle factors to turn
that into a current system time. When using emulated TSC in the guest
(tsc_mode=0,1) then the TSC values it sees, and the offsets and scale
factors it applies, are different. It is intended that it should result in
the same values being computed for NOW(), but I suppose something could be
going wrong there. By how much have you seen guest and hypervisor disagree?

 -- Keir

  reply	other threads:[~2011-08-31 21:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-28 13:13 xen-4.1: PV domain hanging at startup, jiffies stopped Marek Marczykowski
2011-08-29 20:07 ` Konrad Rzeszutek Wilk
2011-08-29 20:21   ` Marek Marczykowski
2011-08-29 20:59     ` Konrad Rzeszutek Wilk
2011-08-29 21:28       ` Pasi Kärkkäinen
2011-08-30 17:18       ` Marek Marczykowski
2011-08-31 16:27         ` Marek Marczykowski
2011-08-31 20:00           ` Dan Magenheimer
2011-08-31 20:49             ` Marek Marczykowski
2011-08-31 21:01               ` Keir Fraser [this message]
2011-08-31 21:13                 ` Marek Marczykowski
2011-08-31 22:07                   ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA845FD0.2013E%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=joanna@invisiblethingslab.com \
    --cc=konrad.wilk@oracle.com \
    --cc=marmarek@mimuw.edu.pl \
    --cc=rafal@invisiblethingslab.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).