From: Keir Fraser <keir.xen@gmail.com>
To: Igor Mammedov <imammedo@redhat.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH v2] xen: x86_32: do not enable iterrupts when returning from exception in interrupt context
Date: Fri, 02 Sep 2011 11:00:48 +0100 [thread overview]
Message-ID: <CA8667E0.20358%keir.xen@gmail.com> (raw)
In-Reply-To: <4E609FA1.3010503@redhat.com>
On 02/09/2011 10:19, "Igor Mammedov" <imammedo@redhat.com> wrote:
> BTW, while debugging this issue, I've tried to print saved_upcall_mask
> inside xen when handling page fault from guest. And it value is always
> 0. Looking at asm code for example in xen/arch/x86/x86_32/entry.S:382
>
> movzwl TRAPBOUNCE_cs(%edx),%eax
> ^^^^^ upper 16-bit is 0 set in propagate_page_fault
> by "tb->cs = ti->cs;"
>
> /* Null selectors (0-3) are not allowed. */
> testl $~3,%eax
> jz domain_crash_synchronous
> movl %eax,UREGS_cs+4(%esp)
> ^^^^^^^^^^^^^^^^ and here is the only place we set
> saved_upcall_mask field in current cpu_user_regs
>
> It looks like "saved_upcall_mask" in cpu_user_regs is not really used
> any more for what it means and it's presence in struct is just confusing
> and misleading.
>
> So why not delete it and extend _pad1 to 4 bytes?
It's part of the guest ABI.
-- Keir
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-09-02 10:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 6:54 Fix the occasional xen-blkfront deadlock, when irqbalancing Daniel Stodden
2010-08-23 6:54 ` [PATCH] blkfront: Move blkif_interrupt into a tasklet Daniel Stodden
2010-08-23 7:01 ` Daniel Stodden
2010-09-02 22:46 ` Jeremy Fitzhardinge
2010-09-02 23:08 ` Daniel Stodden
2010-09-07 1:39 ` blktap lockdep hiccup Jeremy Fitzhardinge
2010-09-07 1:46 ` Daniel Stodden
2010-09-08 2:03 ` [PATCH] blkfront: Move blkif_interrupt into a tasklet Jeremy Fitzhardinge
2010-09-08 2:21 ` Daniel Stodden
2010-09-08 6:37 ` Jeremy Fitzhardinge
2010-09-23 16:08 ` Andrew Jones
2010-09-23 16:23 ` Jeremy Fitzhardinge
2010-09-23 16:38 ` Paolo Bonzini
2010-09-23 18:36 ` Jeremy Fitzhardinge
2010-09-24 7:14 ` Andrew Jones
2010-09-24 18:50 ` Jeremy Fitzhardinge
2010-09-27 7:41 ` Andrew Jones
2010-09-27 9:46 ` Daniel Stodden
2010-09-27 10:21 ` Andrew Jones
2011-08-16 11:26 ` imammedo
2011-08-16 14:57 ` Konrad Rzeszutek Wilk
2011-08-17 2:38 ` Konrad Rzeszutek Wilk
2011-08-17 7:30 ` Paolo Bonzini
2011-08-17 9:07 ` Igor Mammedov
2011-08-24 15:36 ` Konrad Rzeszutek Wilk
2011-08-24 16:36 ` Igor Mammedov
2011-08-29 19:46 ` Konrad Rzeszutek Wilk
2011-08-31 23:47 ` [PATCH] xen: x86_32: do not enable iterrupts when returning from exception in interrupt context Igor Mammedov
2011-08-31 22:37 ` Jeremy Fitzhardinge
2011-09-01 8:19 ` Igor Mammedov
2011-09-01 11:46 ` [PATCH v2] " Igor Mammedov
2011-09-01 15:45 ` Konrad Rzeszutek Wilk
2011-09-01 16:46 ` Jeremy Fitzhardinge
2011-09-02 8:18 ` Igor Mammedov
2011-09-02 13:40 ` Konrad Rzeszutek Wilk
2011-09-02 14:01 ` [Xen-devel] " Igor Mammedov
2011-09-02 14:47 ` Konrad Rzeszutek Wilk
2011-09-06 9:16 ` Igor Mammedov
2011-09-02 9:19 ` Igor Mammedov
2011-09-02 10:00 ` Keir Fraser [this message]
2010-08-23 21:09 ` Fix the occasional xen-blkfront deadlock, when irqbalancing Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA8667E0.20358%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=imammedo@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).