From: Zhigang Wang <w1z2g3@gmail.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] libxl: fix bootloader args setting
Date: Fri, 3 Feb 2012 16:41:25 -0500 [thread overview]
Message-ID: <CAAarEA+7jcovDmn-++4-FRdUhrkp_J5pma6Bxt6dZWYR9akasw@mail.gmail.com> (raw)
In-Reply-To: <9ae3b2b7b494ab8fbc54.1328294398@zhigang.us.oracle.com>
Sorry to send duplicate patches. The first mail took a few hours to
show up in this mailing list. So I thought it didn't work. Will wait
longer next time ...
Zhigang
On Fri, Feb 3, 2012 at 1:39 PM, Zhigang Wang <zhigang.x.wang@oracle.com> wrote:
> # HG changeset patch
> # User Zhigang Wang <zhigang.x.wang@oracle.com>
> # Date 1328294351 18000
> # Node ID 9ae3b2b7b494ab8fbc54aa923101dc48132c6c6e
> # Parent e2722b24dc0962de37215320b05d1bb7c4c42864
> libxl: fix bootloader args setting
>
> Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>
>
> diff -r e2722b24dc09 -r 9ae3b2b7b494 tools/libxl/libxl_bootloader.c
> --- a/tools/libxl/libxl_bootloader.c Thu Jan 26 17:43:31 2012 +0000
> +++ b/tools/libxl/libxl_bootloader.c Fri Feb 03 13:39:11 2012 -0500
> @@ -49,9 +49,11 @@ static char **make_bootloader_args(libxl
> flexarray_set(args, nr++, libxl__sprintf(gc, "--output-directory=%s", "/var/run/libxl/"));
>
> if (info->u.pv.bootloader_args) {
> - char *p = info->u.pv.bootloader_args[0];
> - while (*(p++))
> - flexarray_set(args, nr++, p);
> + char **p = info->u.pv.bootloader_args;
> + while (*p) {
> + flexarray_set(args, nr++, *p);
> + p++;
> + }
> }
>
> flexarray_set(args, nr++, disk);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2012-02-03 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 18:39 [PATCH] libxl: fix bootloader args setting Zhigang Wang
2012-02-03 21:41 ` Zhigang Wang [this message]
2012-02-04 8:57 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2012-02-03 20:10 Zhigang Wang
2012-02-06 15:06 Zhigang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAarEA+7jcovDmn-++4-FRdUhrkp_J5pma6Bxt6dZWYR9akasw@mail.gmail.com \
--to=w1z2g3@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).