From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aravindh Puthiyaparambil Subject: Re: [PATCH v2 0/4] XEN: fix vmx exception mistake Date: Thu, 31 May 2012 16:21:33 -0700 Message-ID: References: <403610A45A2B5242BD291EDAE8B37D300FDCB4CB@SHSMSX102.ccr.corp.intel.com> <403610A45A2B5242BD291EDAE8B37D300FDCBB4F@SHSMSX102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <403610A45A2B5242BD291EDAE8B37D300FDCBB4F@SHSMSX102.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Hao, Xudong" Cc: Keir Fraser , "Dong, Eddie" , Ian Jackson , "xen-devel@lists.xen.org" , "JBeulich@suse.com" , "Zhang, Xiantao" List-Id: xen-devel@lists.xenproject.org On Wed, May 30, 2012 at 7:00 PM, Hao, Xudong wrote: > Hi, Aravindh > > This series patches has be checked in xen unstable tree Cset#25424~25429(= except for #25426), can you test by your case? I ran my tests (injecting software interrupts and hardware exceptions) and they all passed. Thanks, Aravindh >> -----Original Message----- >> From: Keir Fraser [mailto:keir.xen@gmail.com] On Behalf Of Keir Fraser >> Sent: Wednesday, May 30, 2012 8:21 PM >> To: Hao, Xudong; JBeulich@suse.com >> Cc: xen-devel@lists.xen.org; Dong, Eddie; Aravindh Puthiyaparambil; Ian >> Jackson >> Subject: Re: [PATCH v2 0/4] XEN: fix vmx exception mistake >> >> On 30/05/2012 12:16, "Hao, Xudong" wrote: >> >> >> -----Original Message----- >> >> From: Keir Fraser [mailto:keir.xen@gmail.com] On Behalf Of Keir Fraser >> >> Sent: Wednesday, May 30, 2012 6:40 PM >> >> To: Hao, Xudong; JBeulich@suse.com >> >> Cc: xen-devel@lists.xen.org; Dong, Eddie; Aravindh Puthiyaparambil; I= an >> >> Jackson >> >> Subject: Re: [PATCH v2 0/4] XEN: fix vmx exception mistake >> >> >> >> On 30/05/2012 03:35, "Xudong Hao" wrote: >> >> >> >>> Changes from v1: >> >>> - Define new struct hvm_trap to represent information of trap, inclu= de >> >>> =A0 instruction length. >> >>> - Renames hvm_inject_exception to hvm_inject_trap. Then define a cou= ple >> of >> >>> =A0 wrappers around that function for existing callers, so that their >> >>> parameter >> >>> =A0 lists actually *shrink*. >> >> >> >> I checked in the series, except for the bit that infers trap type from >> >> within vmx_inject_trap(). Instead I plumbed through a trap-type field= to >> >> dom0 toolstack, so the type can be specified by the caller. >> >> >> > >> > Thanks, that's more clean. >> > >> > The INT3 trap type should be HVMOP_TRAP_sw_exc in >> > tools/tests/xen-access/xen-access.c. >> >> Thanks I'll fix it and renam einslen -> insn_len as Jan suggested. >> >> =A0-- Keir >> >> >