* [PATCH] tools: adds tracer on qemu-xen debug configure options
@ 2013-09-27 14:00 Fabio Fantoni
2013-09-30 11:21 ` Stefano Stabellini
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Fabio Fantoni @ 2013-09-27 14:00 UTC (permalink / raw)
To: xen-devel
Cc: George.Dunlap, Fabio Fantoni, Ian.Jackson, Ian.Campbell,
Stefano.Stabellini
When building tools in debug mode (debug=y), pass also
--enable-trace-backend=stderr when configuring qemu-xen.
Useful to improve debug.
Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
---
tools/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile
index e7a983b..77a3522 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -174,7 +174,7 @@ qemu-xen-dir-force-update:
fi
ifeq ($(debug),y)
-QEMU_XEN_ENABLE_DEBUG := --enable-debug
+QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr
else
QEMU_XEN_ENABLE_DEBUG :=
endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-09-27 14:00 [PATCH] tools: adds tracer on qemu-xen debug configure options Fabio Fantoni
@ 2013-09-30 11:21 ` Stefano Stabellini
2013-10-03 13:08 ` Ian Campbell
2013-10-11 18:08 ` Ian Jackson
2 siblings, 0 replies; 11+ messages in thread
From: Stefano Stabellini @ 2013-09-30 11:21 UTC (permalink / raw)
To: Fabio Fantoni
Cc: George.Dunlap, xen-devel, Ian.Jackson, Ian.Campbell,
Stefano.Stabellini
On Fri, 27 Sep 2013, Fabio Fantoni wrote:
> When building tools in debug mode (debug=y), pass also
> --enable-trace-backend=stderr when configuring qemu-xen.
> Useful to improve debug.
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> tools/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index e7a983b..77a3522 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -174,7 +174,7 @@ qemu-xen-dir-force-update:
> fi
>
> ifeq ($(debug),y)
> -QEMU_XEN_ENABLE_DEBUG := --enable-debug
> +QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr
> else
> QEMU_XEN_ENABLE_DEBUG :=
> endif
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-09-27 14:00 [PATCH] tools: adds tracer on qemu-xen debug configure options Fabio Fantoni
2013-09-30 11:21 ` Stefano Stabellini
@ 2013-10-03 13:08 ` Ian Campbell
2013-10-03 13:35 ` Fabio Fantoni
2013-10-11 18:08 ` Ian Jackson
2 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2013-10-03 13:08 UTC (permalink / raw)
To: Fabio Fantoni; +Cc: George.Dunlap, xen-devel, Ian.Jackson, Stefano.Stabellini
On Fri, 2013-09-27 at 16:00 +0200, Fabio Fantoni wrote:
> When building tools in debug mode (debug=y), pass also
> --enable-trace-backend=stderr when configuring qemu-xen.
> Useful to improve debug.
What does this actually do in practice? More logging
in /var/log/xen/qemu-dm-$dom.log or something else?
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> ---
> tools/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index e7a983b..77a3522 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -174,7 +174,7 @@ qemu-xen-dir-force-update:
> fi
>
> ifeq ($(debug),y)
> -QEMU_XEN_ENABLE_DEBUG := --enable-debug
> +QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr
> else
> QEMU_XEN_ENABLE_DEBUG :=
> endif
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-10-03 13:08 ` Ian Campbell
@ 2013-10-03 13:35 ` Fabio Fantoni
2013-10-10 8:14 ` Fabio Fantoni
0 siblings, 1 reply; 11+ messages in thread
From: Fabio Fantoni @ 2013-10-03 13:35 UTC (permalink / raw)
To: Ian Campbell; +Cc: George.Dunlap, xen-devel, Ian.Jackson, Stefano.Stabellini
Il 03/10/2013 15:08, Ian Campbell ha scritto:
> On Fri, 2013-09-27 at 16:00 +0200, Fabio Fantoni wrote:
>> When building tools in debug mode (debug=y), pass also
>> --enable-trace-backend=stderr when configuring qemu-xen.
>> Useful to improve debug.
> What does this actually do in practice? More logging
> in /var/log/xen/qemu-dm-$dom.log or something else?
Yes, I think that stderr backend is good because the log will go on
/var/log/xen/qemu-dm-$dom.log (easy and fast).
To use it must be configured with some qemu parameters, containing the
type of events to log. Setting it with "device_model_args" should be
sufficent instead adding other libxl option, and this should be used
only on some debug case.
All details here:
http://git.qemu.org/?p=qemu.git;a=blob;f=docs/tracing.txt
>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>> ---
>> tools/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index e7a983b..77a3522 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -174,7 +174,7 @@ qemu-xen-dir-force-update:
>> fi
>>
>> ifeq ($(debug),y)
>> -QEMU_XEN_ENABLE_DEBUG := --enable-debug
>> +QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr
>> else
>> QEMU_XEN_ENABLE_DEBUG :=
>> endif
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-10-03 13:35 ` Fabio Fantoni
@ 2013-10-10 8:14 ` Fabio Fantoni
2013-10-10 8:52 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Fabio Fantoni @ 2013-10-10 8:14 UTC (permalink / raw)
To: Ian Campbell; +Cc: George.Dunlap, xen-devel, Ian.Jackson, Stefano.Stabellini
Il 03/10/2013 15:35, Fabio Fantoni ha scritto:
> Il 03/10/2013 15:08, Ian Campbell ha scritto:
>> On Fri, 2013-09-27 at 16:00 +0200, Fabio Fantoni wrote:
>>> When building tools in debug mode (debug=y), pass also
>>> --enable-trace-backend=stderr when configuring qemu-xen.
>>> Useful to improve debug.
>> What does this actually do in practice? More logging
>> in /var/log/xen/qemu-dm-$dom.log or something else?
>
> Yes, I think that stderr backend is good because the log will go on
> /var/log/xen/qemu-dm-$dom.log (easy and fast).
> To use it must be configured with some qemu parameters, containing the
> type of events to log. Setting it with "device_model_args" should be
> sufficent instead adding other libxl option, and this should be used
> only on some debug case.
> All details here:
> http://git.qemu.org/?p=qemu.git;a=blob;f=docs/tracing.txt
>
Any hints on this?
>>
>>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>>> ---
>>> tools/Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/Makefile b/tools/Makefile
>>> index e7a983b..77a3522 100644
>>> --- a/tools/Makefile
>>> +++ b/tools/Makefile
>>> @@ -174,7 +174,7 @@ qemu-xen-dir-force-update:
>>> fi
>>> ifeq ($(debug),y)
>>> -QEMU_XEN_ENABLE_DEBUG := --enable-debug
>>> +QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr
>>> else
>>> QEMU_XEN_ENABLE_DEBUG :=
>>> endif
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-10-10 8:14 ` Fabio Fantoni
@ 2013-10-10 8:52 ` Ian Campbell
2013-10-10 10:36 ` Stefano Stabellini
2013-10-10 11:27 ` Anthony PERARD
0 siblings, 2 replies; 11+ messages in thread
From: Ian Campbell @ 2013-10-10 8:52 UTC (permalink / raw)
To: Fabio Fantoni
Cc: George.Dunlap, Anthony Perard, xen-devel, Ian.Jackson,
Stefano.Stabellini
On Thu, 2013-10-10 at 10:14 +0200, Fabio Fantoni wrote:
> Il 03/10/2013 15:35, Fabio Fantoni ha scritto:
> > Il 03/10/2013 15:08, Ian Campbell ha scritto:
> >> On Fri, 2013-09-27 at 16:00 +0200, Fabio Fantoni wrote:
> >>> When building tools in debug mode (debug=y), pass also
> >>> --enable-trace-backend=stderr when configuring qemu-xen.
> >>> Useful to improve debug.
> >> What does this actually do in practice? More logging
> >> in /var/log/xen/qemu-dm-$dom.log or something else?
> >
> > Yes, I think that stderr backend is good because the log will go on
> > /var/log/xen/qemu-dm-$dom.log (easy and fast).
> > To use it must be configured with some qemu parameters, containing the
> > type of events to log. Setting it with "device_model_args" should be
> > sufficent instead adding other libxl option, and this should be used
> > only on some debug case.
> > All details here:
> > http://git.qemu.org/?p=qemu.git;a=blob;f=docs/tracing.txt
> >
>
> Any hints on this?
I missed Stefano's ack and was waiting for a qemu person to chime in,
sorry.
There was some previous discussion about whether this kind tracing was
the right solution:
http://thread.gmane.org/gmane.comp.emulators.xen.devel/164858/focus=165379
I guess however that enabling this in our own debug builds of qemu (i.e.
this patch) is OK, but long term something which can work for distro
qemu builds would be better.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-10-10 8:52 ` Ian Campbell
@ 2013-10-10 10:36 ` Stefano Stabellini
2013-10-10 11:42 ` Ian Campbell
2013-10-10 11:27 ` Anthony PERARD
1 sibling, 1 reply; 11+ messages in thread
From: Stefano Stabellini @ 2013-10-10 10:36 UTC (permalink / raw)
To: Ian Campbell
Cc: xen-devel, Stefano.Stabellini, George.Dunlap, Ian.Jackson,
Fabio Fantoni, Anthony Perard
On Thu, 10 Oct 2013, Ian Campbell wrote:
> On Thu, 2013-10-10 at 10:14 +0200, Fabio Fantoni wrote:
> > Il 03/10/2013 15:35, Fabio Fantoni ha scritto:
> > > Il 03/10/2013 15:08, Ian Campbell ha scritto:
> > >> On Fri, 2013-09-27 at 16:00 +0200, Fabio Fantoni wrote:
> > >>> When building tools in debug mode (debug=y), pass also
> > >>> --enable-trace-backend=stderr when configuring qemu-xen.
> > >>> Useful to improve debug.
> > >> What does this actually do in practice? More logging
> > >> in /var/log/xen/qemu-dm-$dom.log or something else?
> > >
> > > Yes, I think that stderr backend is good because the log will go on
> > > /var/log/xen/qemu-dm-$dom.log (easy and fast).
> > > To use it must be configured with some qemu parameters, containing the
> > > type of events to log. Setting it with "device_model_args" should be
> > > sufficent instead adding other libxl option, and this should be used
> > > only on some debug case.
> > > All details here:
> > > http://git.qemu.org/?p=qemu.git;a=blob;f=docs/tracing.txt
> > >
> >
> > Any hints on this?
>
> I missed Stefano's ack and was waiting for a qemu person to chime in,
> sorry.
>
> There was some previous discussion about whether this kind tracing was
> the right solution:
> http://thread.gmane.org/gmane.comp.emulators.xen.devel/164858/focus=165379
>
> I guess however that enabling this in our own debug builds of qemu (i.e.
> this patch) is OK, but long term something which can work for distro
> qemu builds would be better.
Passing --enable-trace-backend=stderr is a good idea.
Ack for this patch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-10-10 10:36 ` Stefano Stabellini
@ 2013-10-10 11:42 ` Ian Campbell
0 siblings, 0 replies; 11+ messages in thread
From: Ian Campbell @ 2013-10-10 11:42 UTC (permalink / raw)
To: Stefano Stabellini
Cc: George.Dunlap, Anthony Perard, Fabio Fantoni, Ian.Jackson,
xen-devel
On Thu, 2013-10-10 at 11:36 +0100, Stefano Stabellini wrote:
> On Thu, 10 Oct 2013, Ian Campbell wrote:
> > On Thu, 2013-10-10 at 10:14 +0200, Fabio Fantoni wrote:
> > > Il 03/10/2013 15:35, Fabio Fantoni ha scritto:
> > > > Il 03/10/2013 15:08, Ian Campbell ha scritto:
> > > >> On Fri, 2013-09-27 at 16:00 +0200, Fabio Fantoni wrote:
> > > >>> When building tools in debug mode (debug=y), pass also
> > > >>> --enable-trace-backend=stderr when configuring qemu-xen.
> > > >>> Useful to improve debug.
> > > >> What does this actually do in practice? More logging
> > > >> in /var/log/xen/qemu-dm-$dom.log or something else?
> > > >
> > > > Yes, I think that stderr backend is good because the log will go on
> > > > /var/log/xen/qemu-dm-$dom.log (easy and fast).
> > > > To use it must be configured with some qemu parameters, containing the
> > > > type of events to log. Setting it with "device_model_args" should be
> > > > sufficent instead adding other libxl option, and this should be used
> > > > only on some debug case.
> > > > All details here:
> > > > http://git.qemu.org/?p=qemu.git;a=blob;f=docs/tracing.txt
> > > >
> > >
> > > Any hints on this?
> >
> > I missed Stefano's ack and was waiting for a qemu person to chime in,
> > sorry.
> >
> > There was some previous discussion about whether this kind tracing was
> > the right solution:
> > http://thread.gmane.org/gmane.comp.emulators.xen.devel/164858/focus=165379
> >
> > I guess however that enabling this in our own debug builds of qemu (i.e.
> > this patch) is OK, but long term something which can work for distro
> > qemu builds would be better.
>
> Passing --enable-trace-backend=stderr is a good idea.
> Ack for this patch.
applied.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-10-10 8:52 ` Ian Campbell
2013-10-10 10:36 ` Stefano Stabellini
@ 2013-10-10 11:27 ` Anthony PERARD
1 sibling, 0 replies; 11+ messages in thread
From: Anthony PERARD @ 2013-10-10 11:27 UTC (permalink / raw)
To: Ian Campbell
Cc: George.Dunlap, Fabio Fantoni, Ian.Jackson, xen-devel,
Stefano.Stabellini
On Thu, Oct 10, 2013 at 09:52:16AM +0100, Ian Campbell wrote:
> On Thu, 2013-10-10 at 10:14 +0200, Fabio Fantoni wrote:
> > Il 03/10/2013 15:35, Fabio Fantoni ha scritto:
> > > Il 03/10/2013 15:08, Ian Campbell ha scritto:
> > >> On Fri, 2013-09-27 at 16:00 +0200, Fabio Fantoni wrote:
> > >>> When building tools in debug mode (debug=y), pass also
> > >>> --enable-trace-backend=stderr when configuring qemu-xen.
> > >>> Useful to improve debug.
> > >> What does this actually do in practice? More logging
> > >> in /var/log/xen/qemu-dm-$dom.log or something else?
> > >
> > > Yes, I think that stderr backend is good because the log will go on
> > > /var/log/xen/qemu-dm-$dom.log (easy and fast).
> > > To use it must be configured with some qemu parameters, containing the
> > > type of events to log. Setting it with "device_model_args" should be
> > > sufficent instead adding other libxl option, and this should be used
> > > only on some debug case.
> > > All details here:
> > > http://git.qemu.org/?p=qemu.git;a=blob;f=docs/tracing.txt
> > >
> >
> > Any hints on this?
>
> I missed Stefano's ack and was waiting for a qemu person to chime in,
> sorry.
>
> There was some previous discussion about whether this kind tracing was
> the right solution:
> http://thread.gmane.org/gmane.comp.emulators.xen.devel/164858/focus=165379
The discussion was for a particular case, and was not about qemu trace
itself.
> I guess however that enabling this in our own debug builds of qemu (i.e.
> this patch) is OK, but long term something which can work for distro
> qemu builds would be better.
Having trace compiled in for debug purpose is a good idee, it make it
possible to enable some extra debug print without recompiling qemu. And
by default, they won't be any extra debug print in the logs.
So ACK to add --enable-trace... to a debug build.
--
Anthony PERARD
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tools: adds tracer on qemu-xen debug configure options
2013-09-27 14:00 [PATCH] tools: adds tracer on qemu-xen debug configure options Fabio Fantoni
2013-09-30 11:21 ` Stefano Stabellini
2013-10-03 13:08 ` Ian Campbell
@ 2013-10-11 18:08 ` Ian Jackson
2013-10-11 18:17 ` Fabio Fantoni
2 siblings, 1 reply; 11+ messages in thread
From: Ian Jackson @ 2013-10-11 18:08 UTC (permalink / raw)
To: Fabio Fantoni; +Cc: George.Dunlap, xen-devel, Ian.Campbell, Stefano.Stabellini
Fabio Fantoni writes ("[PATCH] tools: adds tracer on qemu-xen debug configure options"):
> When building tools in debug mode (debug=y), pass also
> --enable-trace-backend=stderr when configuring qemu-xen.
> Useful to improve debug.
This sounds plausible to me but Stefano may disagree ?
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-10-11 18:17 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 14:00 [PATCH] tools: adds tracer on qemu-xen debug configure options Fabio Fantoni
2013-09-30 11:21 ` Stefano Stabellini
2013-10-03 13:08 ` Ian Campbell
2013-10-03 13:35 ` Fabio Fantoni
2013-10-10 8:14 ` Fabio Fantoni
2013-10-10 8:52 ` Ian Campbell
2013-10-10 10:36 ` Stefano Stabellini
2013-10-10 11:42 ` Ian Campbell
2013-10-10 11:27 ` Anthony PERARD
2013-10-11 18:08 ` Ian Jackson
2013-10-11 18:17 ` Fabio Fantoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).