From: Praveen Kumar <kpraveen.lkml@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 01/20] rbtree: add const qualifier to some functions
Date: Mon, 19 Jun 2017 19:39:54 +0530 [thread overview]
Message-ID: <CABcWhv5k404x3VJSFb7w0mk13NQRvF1r6n8yL7E4jD6Cy77p_w@mail.gmail.com> (raw)
In-Reply-To: <5947F26E0200007800164129@prv-mh.provo.novell.com>
Hi Jan,
On Mon, Jun 19, 2017 at 7:19 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 17.06.17 at 11:32, <kpraveen.lkml@gmail.com> wrote:
>> The 'rb_first()', 'rb_last()', 'rb_next()' and 'rb_prev()' calls
>> take a pointer to an RB node or RB root. They do not change the
>> pointed objects, so add a 'const' qualifier in order to make life
>> of the users of these functions easier.
>>
>> Indeed, if I have my own constant pointer &const struct my_type *p,
>> and I call 'rb_next(&p->rb)', I get a GCC warning:
>>
>> warning: passing argument 1 of ‘rb_next’ discards qualifiers from pointer target
>> type
>>
>> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
>> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>> [Linux commit f4b477c47332367d35686bd2b808c2156b96d7c7]
>>
>> Ported to Xen.
>>
>> Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
>
> This looks okay now from a content pov, but I still have a question
> and a remark.
>
> Question: Who's the original author? According to the Linux commit,
> it's Artem, but without an explicit From: tag I think anyone trying to
> "git am" you mail would put you in as the author. With this taken
> care of (which the committer may be willing to do)
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
Thanks for your input.
Pardon me, I am new to the forum. The Ack you added is only for this patch.
Also, do you want me to add 'From' and resend ?
To be precise in below order :
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[Linux commit f4b477c47332367d35686bd2b808c2156b96d7c7]
Ported to Xen.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
Please do correct me if my understanding is wrong. Thanks.
> Remark: You've sent v3 of the series. This patch has no version
> indicator at all, and most other patches say v2. This is all quite
> inconsistent, and prevents easily identifying the various pieces
> belonging together when not using a threaded view. If you add
> new patches to a series, don't start them at v1. Instead in the
> brief revision info (after the first --- marker) simply say "New in
> v3."
>
Sure, my mistake. I was not aware of the same. I will take care in
future patches.
Thanks for your input.
Regards,
~Praveen.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-19 14:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 9:32 [PATCH v3] xen: common: rbtree: ported updates from Praveen Kumar
2017-06-17 9:32 ` [PATCH 01/20] rbtree: add const qualifier to some functions Praveen Kumar
2017-06-19 13:49 ` Jan Beulich
2017-06-19 14:09 ` Praveen Kumar [this message]
2017-06-19 14:47 ` Jan Beulich
2017-06-19 16:39 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH 02/20] lib/rbtree.c: optimize rb_erase() Praveen Kumar
2017-06-19 16:41 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH v2 03/20] rb_tree: reorganize code in rb_erase() for additional changes Praveen Kumar
2017-06-19 16:45 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH v2 04/20] rb_tree: make clear distinction between two different cases in rb_erase() Praveen Kumar
2017-06-19 16:47 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH v2 05/20] rb_tree: remove redundant if()-condition " Praveen Kumar
2017-06-19 16:53 ` Dario Faggioli
2017-06-20 7:23 ` Jan Beulich
2017-06-17 9:32 ` [PATCH v2 06/20] rbtree: empty nodes have no color Praveen Kumar
2017-06-19 17:00 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH v2 07/20] rbtree: move some implementation details from rbtree.h to rbtree.c Praveen Kumar
2017-06-19 17:05 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH v2 08/20] rbtree: break out of rb_insert_color loop after tree rotation Praveen Kumar
2017-06-19 17:10 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH v2 09/20] rbtree: adjust root color in rb_insert_color() only when necessary Praveen Kumar
2017-06-19 17:13 ` Dario Faggioli
2017-06-20 7:26 ` Jan Beulich
2017-06-20 13:54 ` Dario Faggioli
2017-06-27 15:35 ` Praveen Kumar
2017-06-27 15:48 ` Dario Faggioli
2017-06-17 9:32 ` [PATCH v2 10/20] rbtree: low level optimizations in rb_insert_color() Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 11/20] rbtree: adjust node color in __rb_erase_color() only when necessary Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 12/20] rbtree: optimize case selection logic in __rb_erase_color() Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 13/20] rbtree: low level optimizations " Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 14/20] rbtree: coding style adjustments Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 15/20] rbtree: optimize fetching of sibling node Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 16/20] rbtree: add __rb_change_child() helper function Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 17/20] rbtree: place easiest case first in rb_erase() Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 18/20] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Praveen Kumar
2017-06-17 9:32 ` [PATCH v2 19/20] rbtree: low level optimizations in rb_erase() Praveen Kumar
2017-06-17 9:32 ` [PATCH 20/20] lib/rbtree.c: fix typo in comment of __rb_insert() Praveen Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABcWhv5k404x3VJSFb7w0mk13NQRvF1r6n8yL7E4jD6Cy77p_w@mail.gmail.com \
--to=kpraveen.lkml@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).