From: Tamas K Lengyel <tamas@tklengyel.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Steve Capper <steve.capper@arm.com>,
Sergej Proskurin <proskurin@sec.in.tum.de>,
Xen-devel <xen-devel@lists.xen.org>,
wei.chen@linaro.org
Subject: Re: [RFC 13/22] xen/arm: p2m: Replace all usage of __p2m_lookup with p2m_get_entry
Date: Fri, 29 Jul 2016 16:36:21 -0600 [thread overview]
Message-ID: <CABfawhkC4QbUk6-XMjwBSqH4dV=h87vC0Nm_+nC455a=WCUHmg@mail.gmail.com> (raw)
In-Reply-To: <1518bc76-c67c-365a-6115-941861fe66b8@arm.com>
On Fri, Jul 29, 2016 at 9:06 AM, Julien Grall <julien.grall@arm.com> wrote:
>
>
> On 28/07/16 18:36, Tamas K Lengyel wrote:
>>
>> On Thu, Jul 28, 2016 at 11:29 AM, Tamas K Lengyel <tamas@tklengyel.com>
>> wrote:
>>>
>>> On Thu, Jul 28, 2016 at 8:51 AM, Julien Grall <julien.grall@arm.com>
>>> wrote:
>>>>
>>>> __p2m_lookup is just a wrapper to p2m_get_entry.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>>>> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
>>>> Cc: Tamas K Lengyel <tamas@tklengyel.com>
>>>>
>>>> ---
>>>> It might be possible to rework the memaccess code to take advantage
>>>> of all the parameters. I will defer this to the memaccess folks.
>>>
>>>
>>> Could you elaborate on what you mean?
>>>
>>
>> Never mind, I see it. Yes, doing __p2m_get_mem_access and then
>> p2m_get_entry later duplicates work. I would suggest just replacing
>> __p2m_get_mem_access with a single call to p2m_get_entry to get both
>> the type and the mem_access setting on the page in a single run.
>
>
> I am not planning to clean-up the memaccess code. Feel free to send a
> follow-up patch for that.
>
Since you are already touching this code you might as well but
whatever, up to you.
Tamas
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-29 22:36 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 14:51 [RFC 00/22] xen/arm: Rework the P2M code to follow break-before-make sequence Julien Grall
2016-07-28 14:51 ` [RFC 01/22] xen/arm: do_trap_instr_abort_guest: Move the IPA computation out of the switch Julien Grall
2016-08-16 0:21 ` Stefano Stabellini
2016-08-16 16:20 ` Julien Grall
2016-08-31 10:01 ` Julien Grall
2016-08-31 19:43 ` Stefano Stabellini
2016-09-06 14:54 ` Julien Grall
2016-07-28 14:51 ` [RFC 02/22] xen/arm: p2m: Store in p2m_domain whether we need to clean the entry Julien Grall
2016-08-16 0:35 ` Stefano Stabellini
2016-08-31 10:29 ` Julien Grall
2016-07-28 14:51 ` [RFC 03/22] xen/arm: p2m: Rename parameter in p2m_{remove, write}_pte Julien Grall
2016-08-16 0:36 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 04/22] xen/arm: p2m: Use typesafe gfn in p2m_mem_access_radix_set Julien Grall
2016-08-16 0:39 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 05/22] xen/arm: traps: Move MMIO emulation code in a separate helper Julien Grall
2016-08-16 0:49 ` Stefano Stabellini
2016-08-31 10:36 ` Julien Grall
2016-07-28 14:51 ` [RFC 06/22] xen/arm: traps: Check the P2M before injecting a data/instruction abort Julien Grall
2016-08-23 1:05 ` Stefano Stabellini
2016-08-31 10:58 ` Julien Grall
2016-07-28 14:51 ` [RFC 07/22] xen/arm: p2m: Rework p2m_put_l3_page Julien Grall
2016-08-23 1:10 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 08/22] xen/arm: p2m: Invalidate the TLBs when write unlocking the p2m Julien Grall
2016-08-23 1:18 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 09/22] xen/arm: p2m: Change the type of level_shifts from paddr_t to unsigned int Julien Grall
2016-08-23 1:20 ` Stefano Stabellini
2016-08-31 11:04 ` Julien Grall
2016-07-28 14:51 ` [RFC 10/22] xen/arm: p2m: Move the lookup helpers at the top of the file Julien Grall
2016-07-28 14:51 ` [RFC 11/22] xen/arm: p2m: Introduce p2m_get_root_pointer and use it in __p2m_lookup Julien Grall
2016-08-23 1:34 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 12/22] xen/arm: p2m: Introduce p2m_get_entry and use it to implement __p2m_lookup Julien Grall
2016-07-30 18:37 ` Tamas K Lengyel
2016-08-31 0:30 ` [RFC 12/22] xen/arm: p2m: Introduce p2m_get_entry and use it to implement __p2m_lookupo Stefano Stabellini
2016-08-31 12:25 ` Julien Grall
2016-08-31 19:33 ` Stefano Stabellini
2016-09-01 11:37 ` Julien Grall
2016-07-28 14:51 ` [RFC 13/22] xen/arm: p2m: Replace all usage of __p2m_lookup with p2m_get_entry Julien Grall
2016-07-28 17:29 ` Tamas K Lengyel
2016-07-28 17:36 ` Tamas K Lengyel
2016-07-29 15:06 ` Julien Grall
2016-07-29 22:36 ` Tamas K Lengyel [this message]
2016-07-28 17:51 ` Julien Grall
2016-09-05 20:45 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 14/22] xen/arm: p2m: Re-implement p2m_cache_flush using p2m_get_entry Julien Grall
2016-09-05 21:13 ` Stefano Stabellini
2016-09-06 14:56 ` Julien Grall
2016-07-28 14:51 ` [RFC 15/22] xen/arm: p2m: Re-implement relinquish_p2m_mapping " Julien Grall
2016-09-05 21:58 ` Stefano Stabellini
2016-09-06 15:05 ` Julien Grall
2016-09-06 18:21 ` Stefano Stabellini
2016-09-07 7:37 ` Julien Grall
2016-07-28 14:51 ` [RFC 16/22] xen/arm: p2m: Make p2m_{valid, table, mapping} helpers inline Julien Grall
2016-09-05 22:00 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 17/22] xen/arm: p2m: Introduce a helper to check if an entry is a superpage Julien Grall
2016-09-05 22:03 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 18/22] xen/arm: p2m: Introduce p2m_set_entry and __p2m_set_entry Julien Grall
2016-07-30 18:40 ` Tamas K Lengyel
2016-08-15 10:22 ` Sergej Proskurin
2016-09-06 1:08 ` Stefano Stabellini
2016-09-06 17:12 ` Julien Grall
2016-09-06 18:51 ` Stefano Stabellini
2016-09-07 8:18 ` Julien Grall
2016-09-09 23:14 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 19/22] xen/arm: p2m: Re-implement p2m_remove_using using p2m_set_entry Julien Grall
2016-09-06 18:53 ` Stefano Stabellini
2016-07-28 14:51 ` [RFC 20/22] xen/arm: p2m: Re-implement p2m_insert_mapping " Julien Grall
2016-09-06 18:57 ` Stefano Stabellini
2016-09-15 10:38 ` Julien Grall
2016-07-28 14:51 ` [RFC 21/22] xen/arm: p2m: Re-implement p2m_set_mem_access using p2m_{set, get}_entry Julien Grall
2016-07-28 15:04 ` Razvan Cojocaru
2016-07-28 15:16 ` Julien Grall
2016-08-01 15:40 ` Julien Grall
2016-08-01 15:59 ` Tamas K Lengyel
2016-08-01 16:15 ` Julien Grall
2016-08-01 16:27 ` Tamas K Lengyel
2016-08-01 16:33 ` Julien Grall
2016-08-01 16:41 ` Tamas K Lengyel
2016-08-02 6:07 ` Razvan Cojocaru
2016-08-01 16:34 ` Mark Rutland
2016-08-01 16:57 ` Julien Grall
2016-08-01 17:26 ` Mark Rutland
2016-08-01 18:22 ` Mark Rutland
2016-08-02 9:58 ` Julien Grall
2016-08-02 10:26 ` Mark Rutland
2016-07-28 17:21 ` Tamas K Lengyel
2016-09-06 19:06 ` Stefano Stabellini
2016-09-06 19:16 ` Razvan Cojocaru
2016-09-06 19:17 ` Stefano Stabellini
2016-09-07 6:56 ` Julien Grall
2016-09-07 7:03 ` Razvan Cojocaru
2016-07-28 14:51 ` [RFC 22/22] xen/arm: p2m: Do not handle shattering in p2m_create_table Julien Grall
2016-09-06 18:59 ` Stefano Stabellini
2016-07-28 17:46 ` [RFC 00/22] xen/arm: Rework the P2M code to follow break-before-make sequence Tamas K Lengyel
2016-07-29 16:23 ` Julien Grall
2016-07-29 19:05 ` Julien Grall
2016-08-15 10:24 ` Julien Grall
2016-08-15 15:06 ` Edgar E. Iglesias
2016-08-17 2:28 ` Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABfawhkC4QbUk6-XMjwBSqH4dV=h87vC0Nm_+nC455a=WCUHmg@mail.gmail.com' \
--to=tamas@tklengyel.com \
--cc=julien.grall@arm.com \
--cc=proskurin@sec.in.tum.de \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=steve.capper@arm.com \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).