From: Tamas K Lengyel <tamas@tklengyel.com>
To: Julien Grall <julien.grall@arm.com>
Cc: andre.przywara@arm.com, sstabellini@kernel.org,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [for-4.7 2/2] xen/arm: traps: Correctly interpret the content of the register HPFAR_EL2
Date: Wed, 13 Apr 2016 13:11:07 -0600 [thread overview]
Message-ID: <CABfawhmUEhqFaNsqvpZWGo_nsGw0HyD1Yo7dOmbJKy17i6mLqA@mail.gmail.com> (raw)
In-Reply-To: <1460562931-19858-3-git-send-email-julien.grall@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 881 bytes --]
On Wed, Apr 13, 2016 at 9:55 AM, Julien Grall <julien.grall@arm.com> wrote:
> The register HPFAR_EL2 (resp. HPFAR on arm32) contains the bits [47:12]
> (resp. [39:12]) of the faulting IPA. Unlike other registers that represent
> an address, the upper bits of the IPA are stored in the register bits
> [4:39] (resp. [4:21]).
>
> However, Xen assumes that the register contains the faulting IPA correctly
> offsetted. This will result to get a wrong IPA when the fault is happening
> during a translation table walk. Note this is only affecting memaccess.
>
> Introduce a new helper to get the faulting IPA from HPFAR_EL2 and
> replace direct read from the register by the helper.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
Thanks for the fix, I totally missed that. I did notice not getting any
events for translation table-walks so at least now I know why.
Tamas
[-- Attachment #1.2: Type: text/html, Size: 1372 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-13 19:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 15:55 [for-4.7 0/2] xen/arm: traps: Correctly interpret the content of the register HPFAR_EL2 Julien Grall
2016-04-13 15:55 ` [for-4.7 1/2] xen/bitops: Introduce macros to generate mask Julien Grall
2016-04-13 18:07 ` Stefano Stabellini
2016-04-13 18:14 ` Andrew Cooper
2016-04-14 8:47 ` Julien Grall
2016-04-14 4:01 ` Jan Beulich
2016-04-14 8:55 ` Julien Grall
2016-04-14 14:56 ` Jan Beulich
2016-04-14 15:08 ` Julien Grall
2016-04-14 15:23 ` Jan Beulich
2016-04-20 12:35 ` Julien Grall
2016-04-20 16:43 ` Jan Beulich
2016-04-22 11:33 ` Julien Grall
2016-04-22 11:49 ` Stefano Stabellini
2016-04-22 15:33 ` Julien Grall
2016-04-22 15:42 ` Stefano Stabellini
2016-04-13 15:55 ` [for-4.7 2/2] xen/arm: traps: Correctly interpret the content of the register HPFAR_EL2 Julien Grall
2016-04-13 18:17 ` Stefano Stabellini
2016-04-13 19:11 ` Tamas K Lengyel [this message]
2016-04-13 20:33 ` André Przywara
2016-04-14 17:47 ` [for-4.7 0/2] " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABfawhmUEhqFaNsqvpZWGo_nsGw0HyD1Yo7dOmbJKy17i6mLqA@mail.gmail.com \
--to=tamas@tklengyel.com \
--cc=andre.przywara@arm.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).