From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH v1 2/4] hvm/svm: Enable Breakpoint events Date: Fri, 2 Feb 2018 08:42:30 -0700 Message-ID: References: <1517564259-32305-1-git-send-email-aisaila@bitdefender.com> <1517564259-32305-3-git-send-email-aisaila@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1517564259-32305-3-git-send-email-aisaila@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Alexandru Isaila Cc: Suravee Suthikulpanit , Razvan Cojocaru , Andrew Cooper , Xen-devel , Jan Beulich , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBGZWIgMiwgMjAxOCBhdCAyOjM3IEFNLCBBbGV4YW5kcnUgSXNhaWxhCjxhaXNhaWxh QGJpdGRlZmVuZGVyLmNvbT4gd3JvdGU6Cj4gVGhpcyBjb21taXQgZW5hYmxlcyB0aGUgYnJlYWtw b2ludCBldmVudHMgZm9yIHN2bS4KPgo+IFNpZ25lZC1vZmYtYnk6IEFsZXhhbmRydSBJc2FpbGEg PGFpc2FpbGFAYml0ZGVmZW5kZXIuY29tPgo+IC0tLQo+ICB4ZW4vYXJjaC94ODYvaHZtL3N2bS9z dm0uYyAgICB8IDUyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0K PiAgeGVuL2luY2x1ZGUvYXNtLXg4Ni9tb25pdG9yLmggfCAgMyArKy0KPiAgMiBmaWxlcyBjaGFu Z2VkLCA0NiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jIGIveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMKPiBp bmRleCBkY2JkNTUwLi4xNGE1ZjYwIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vc3Zt L3N2bS5jCj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMKPiBAQCAtNTksNiArNTks NyBAQAo+ICAjaW5jbHVkZSA8YXNtL2hhcC5oPgo+ICAjaW5jbHVkZSA8YXNtL2FwaWMuaD4KPiAg I2luY2x1ZGUgPGFzbS9kZWJ1Z2dlci5oPgo+ICsjaW5jbHVkZSA8YXNtL2h2bS9tb25pdG9yLmg+ Cj4gICNpbmNsdWRlIDxhc20veHN0YXRlLmg+Cj4KPiAgdm9pZCBzdm1fYXNtX2RvX3Jlc3VtZSh2 b2lkKTsKPiBAQCAtMTA3OSw3ICsxMDgwLDggQEAgc3RhdGljIHZvaWQgc3ZtX2N0eHRfc3dpdGNo X3RvKHN0cnVjdCB2Y3B1ICp2KQo+ICBzdGF0aWMgdm9pZCBub3JldHVybiBzdm1fZG9fcmVzdW1l KHN0cnVjdCB2Y3B1ICp2KQo+ICB7Cj4gICAgICBzdHJ1Y3Qgdm1jYl9zdHJ1Y3QgKnZtY2IgPSB2 LT5hcmNoLmh2bV9zdm0udm1jYjsKPiAtICAgIGJvb2xfdCBkZWJ1Z19zdGF0ZSA9IHYtPmRvbWFp bi0+ZGVidWdnZXJfYXR0YWNoZWQ7Cj4gKyAgICBib29sX3QgZGVidWdfc3RhdGUgPSB2LT5kb21h aW4tPmRlYnVnZ2VyX2F0dGFjaGVkCj4gKyAgICAgICAgICAgICAgICB8fCB2LT5kb21haW4tPmFy Y2gubW9uaXRvci5zb2Z0d2FyZV9icmVha3BvaW50X2VuYWJsZWQ7Cj4gICAgICBib29sX3QgdmNw dV9ndWVzdG1vZGUgPSAwOwo+ICAgICAgc3RydWN0IHZsYXBpYyAqdmxhcGljID0gdmNwdV92bGFw aWModik7Cj4KPiBAQCAtMjQwNyw2ICsyNDA5LDIzIEBAIHN0YXRpYyBib29sIHN2bV9nZXRfcGVu ZGluZ19ldmVudChzdHJ1Y3QgdmNwdSAqdiwgc3RydWN0IHg4Nl9ldmVudCAqaW5mbykKPiAgICAg IHJldHVybiB0cnVlOwo+ICB9Cj4KPiArc3RhdGljIHZvaWQgc3ZtX3Byb3BhZ2F0ZV9pbnRyKHN0 cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGluc25fbGVuKQo+ICt7Cj4gKyAgICBzdHJ1Y3Qg dm1jYl9zdHJ1Y3QgKnZtY2IgPSB2LT5hcmNoLmh2bV9zdm0udm1jYjsKPiArICAgIHN0cnVjdCB4 ODZfZXZlbnQgZXZlbnQgPSB7Cj4gKyAgICAgICAgLnZlY3RvciA9IHZtY2ItPmV2ZW50aW5qLmZp ZWxkcy50eXBlLAo+ICsgICAgICAgIC50eXBlID0gdm1jYi0+ZXZlbnRpbmouZmllbGRzLnR5cGUs Cj4gKyAgICAgICAgLmVycm9yX2NvZGUgPSB2bWNiLT5leGl0aW5mbzEsCj4gKyAgICB9Owo+ICsK PiArICAgIGlmICggZXZlbnQudHlwZSA+PSBYODZfRVZFTlRUWVBFX1NXX0lOVEVSUlVQVCApCj4g KyAgICAgICAgZXZlbnQuaW5zbl9sZW4gPSBpbnNuX2xlbjtzZWVtcwo+ICsgICAgZWxzZQo+ICsg ICAgICAgIGV2ZW50Lmluc25fbGVuID0gMDsKPiArCj4gKyAgICBodm1faW5qZWN0X2V2ZW50KCZl dmVudCk7Cj4gK30KPiArCj4gIHN0YXRpYyBzdHJ1Y3QgaHZtX2Z1bmN0aW9uX3RhYmxlIF9faW5p dGRhdGEgc3ZtX2Z1bmN0aW9uX3RhYmxlID0gewo+ICAgICAgLm5hbWUgICAgICAgICAgICAgICAg ID0gIlNWTSIsCj4gICAgICAuY3B1X3VwX3ByZXBhcmUgICAgICAgPSBzdm1fY3B1X3VwX3ByZXBh cmUsCj4gQEAgLTI2MTksMTQgKzI2MzgsMzEgQEAgdm9pZCBzdm1fdm1leGl0X2hhbmRsZXIoc3Ry dWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpCj4gICAgICAgICAgYnJlYWs7Cj4KPiAgICAgIGNhc2Ug Vk1FWElUX0VYQ0VQVElPTl9CUDoKPiAtICAgICAgICBpZiAoICF2LT5kb21haW4tPmRlYnVnZ2Vy X2F0dGFjaGVkICkKPiAtICAgICAgICAgICAgZ290byB1bmV4cGVjdGVkX2V4aXRfdHlwZTsKPiAt ICAgICAgICAvKiBBTUQgVm9sMiwgMTUuMTE6IElOVDMsIElOVE8sIEJPVU5EIGludGVyY2VwdHMg ZG8gbm90IHVwZGF0ZSBSSVAuICovCj4gLSAgICAgICAgaWYgKCAoaW5zdF9sZW4gPSBfX2dldF9p bnN0cnVjdGlvbl9sZW5ndGgodiwgSU5TVFJfSU5UMykpID09IDAgKQo+ICsgICAgICAgIGluc3Rf bGVuID0gX19nZXRfaW5zdHJ1Y3Rpb25fbGVuZ3RoKHYsIElOU1RSX0lOVDMpOwo+ICsKPiArICAg ICAgICBpZiAoIGluc3RfbGVuID09IDAgKQo+ICAgICAgICAgICAgICBicmVhazsKPiAtICAgICAg ICBfX3VwZGF0ZV9ndWVzdF9laXAocmVncywgaW5zdF9sZW4pOwo+IC0gICAgICAgIGN1cnJlbnQt PmFyY2guZ2Ric3hfdmNwdV9ldmVudCA9IFRSQVBfaW50MzsKPiAtICAgICAgICBkb21haW5fcGF1 c2VfZm9yX2RlYnVnZ2VyKCk7Cj4gKwo+ICsgICAgICAgIGlmICggIXYtPmRvbWFpbi0+ZGVidWdn ZXJfYXR0YWNoZWQgKQoKSSB0aGluayB0aGlzIHdvdWxkIGJlIGVhc2llciB0byBmb2xsb3cgaWYg eW91IHN3aXRjaGVkIGl0IGFyb3VuZC4KCj4gKyAgICAgICAgewo+ICsgICAgICAgICAvKiBBTUQg Vm9sMiwgMTUuMTE6IElOVDMsIElOVE8sIEJPVU5EIGludGVyY2VwdHMgZG8gbm90IHVwZGF0ZSBS SVAuICovCj4gKyAgICAgICAgICAgIGludCByYzsKPiArCj4gKyAgICAgICAgICAgIHJjID0gaHZt X21vbml0b3JfZGVidWcocmVncy0+cmlwLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEhWTV9NT05JVE9SX1NPRlRXQVJFX0JSRUFLUE9JTlQsCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgWDg2X0VWRU5UVFlQRV9TV19FWENFUFRJT04sCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5zdF9sZW4pOwo+ICsgICAgICAgICAgICBp ZiAoIHJjIDwgMCApCj4gKyAgICAgICAgICAgICAgICBnb3RvIHVuZXhwZWN0ZWRfZXhpdF90eXBl Owo+ICsgICAgICAgICAgICBpZiAoICFyYyApCj4gKyAgICAgICAgICAgICAgICBzdm1fcHJvcGFn YXRlX2ludHIodiwgaW5zdF9sZW4pOwo+ICsgICAgICAgIH0KPiArICAgICAgICBlbHNlCj4gKyAg ICAgICAgewo+ICsgICAgICAgICAgICBfX3VwZGF0ZV9ndWVzdF9laXAocmVncywgaW5zdF9sZW4p Owo+ICsgICAgICAgICAgICBjdXJyZW50LT5hcmNoLmdkYnN4X3ZjcHVfZXZlbnQgPSBUUkFQX2lu dDM7Cj4gKyAgICAgICAgICAgIGRvbWFpbl9wYXVzZV9mb3JfZGVidWdnZXIoKTsKPiArICAgICAg ICB9Cj4gICAgICAgICAgYnJlYWs7Cj4KPiAgICAgIGNhc2UgVk1FWElUX0VYQ0VQVElPTl9OTToK PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9tb25pdG9yLmggYi94ZW4vaW5jbHVk ZS9hc20teDg2L21vbml0b3IuaAo+IGluZGV4IDM3MDZiN2EuLjY4YTIxMGEgMTAwNjQ0Cj4gLS0t IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9tb25pdG9yLmgKPiArKysgYi94ZW4vaW5jbHVkZS9hc20t eDg2L21vbml0b3IuaAo+IEBAIC05NCw3ICs5NCw4IEBAIHN0YXRpYyBpbmxpbmUgdWludDMyX3Qg YXJjaF9tb25pdG9yX2dldF9jYXBhYmlsaXRpZXMoc3RydWN0IGRvbWFpbiAqZCkKPiAgICAgIH0K PiAgICAgIGVsc2UgaWYgKCBjcHVfaGFzX3N2bSApCj4gICAgICB7Cj4gLSAgICAgICAgY2FwYWJp bGl0aWVzID0gKDFVIDw8IFhFTl9ET01DVExfTU9OSVRPUl9FVkVOVF9HVUVTVF9SRVFVRVNUKTsK PiArICAgICAgICBjYXBhYmlsaXRpZXMgPSAoMVUgPDwgWEVOX0RPTUNUTF9NT05JVE9SX0VWRU5U X0dVRVNUX1JFUVVFU1QpIHwKPiArICAgICAgICAgICAgICAgICAgICAgICAoMVUgPDwgWEVOX0RP TUNUTF9NT05JVE9SX0VWRU5UX1NPRlRXQVJFX0JSRUFLUE9JTlQpOwoKU2luY2UgYnJlYWtwb2lu dHMgYXJlIGFsc28gc3VwcG9ydGVkIGZvciBib3RoIHN2bSBhbmQgdm14LCB5b3UgY2FuCmp1c3Qg c2V0IGl0IG9uY2UsIG5vIG5lZWQgZm9yIHRoZSBleHRyYSBpZiBibG9jay4KClRhbWFzCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhl bnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs