From mboxrd@z Thu Jan 1 00:00:00 1970 From: Parth Dixit Subject: Re: [PATCH v2 16/41] acpi : Introduce acpi_parse_entries Date: Sun, 5 Jul 2015 18:41:33 +0530 Message-ID: References: <1431893048-5214-1-git-send-email-parth.dixit@linaro.org> <1431893048-5214-17-git-send-email-parth.dixit@linaro.org> <555CCED9020000780007C5E7@mail.emea.novell.com> <555DBF76020000780007C9FF@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <555DBF76020000780007C9FF@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: shannon.zhao@linaro.org Cc: keir@xen.org, Ian Campbell , andrew.cooper3@citrix.com, tim@xen.org, xen-devel , Julien Grall , Stefano Stabellini , Jan Beulich , Christoffer Dall List-Id: xen-devel@lists.xenproject.org +shannon On 21 May 2015 at 14:50, Jan Beulich wrote: >>>> On 21.05.15 at 11:14, wrote: >> On 20 May 2015 at 21:43, Jan Beulich wrote: >> >>> >>> On 17.05.15 at 22:03, wrote: >>> > add new function acpi_parse_entries which takes >>> > acpi table as argument. This will avoid fetching table >>> > everytime in acpi_table_parse_entries. >>> >>> This explanation doesn't make a lot of sense to me - I don't see you >>> save anything. Am I missing anything? Are you intending to use the >>> new function separately? Also, please don't break indentation like >>> >> yes, i am fetching the table once and parsing it with this function in >> acpi_gicv2_init function in the patch given below >> http://lists.xen.org/archives/html/xen-devel/2015-05/msg02208.html > > So - just like elsewhere - please correct the patch description then. > > Jan >