From: Andrii Anisov <andrii.anisov@gmail.com>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/8] xen/arm: p2m: Introduce p2m_get_page_from_gfn
Date: Thu, 15 Nov 2018 15:35:02 +0200 [thread overview]
Message-ID: <CAC1WxdipyzheoV21ftr7KgAgb4iPTA_4tHD3++Qv2KE8EO7npA@mail.gmail.com> (raw)
In-Reply-To: <CAC1Wxdiko1Avrnxinq4Nk2+9=f9V2GHPvAzwGrRv5nH7WBe=qg@mail.gmail.com>
Sorry,
Not "comparingly complex", but "equally complex". ;)
Sincerely,
Andrii Anisov.
чт, 15 лист. 2018 о 15:31 Andrii Anisov <andrii.anisov@gmail.com> пише:
>
> Hello Julien,
>
> вт, 6 лист. 2018 о 21:16 Julien Grall <julien.grall@arm.com> пише:
> >
> > In a follow-up patches, we will need to handle get_page_from_gfn
> > differently for DOMID_XEN. To keep the code simple move the current
> > content in a new separate helper p2m_get_page_from_gfn.
> >
> > Note the new helper is a not anymore a static inline function as the helper
> > is quite complex.
>
> In the patch "[PATCH 4/8] xen/arm: Add support for read-only foreign
> mappings" you make p2m_get_page_from_gfn() comparingly complex, but
> still keep it as static inline. Could you please be consistent (making
> both of those functions inline or non-inline)
>
> Sincerely,
> Andrii Anisov.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-15 13:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 19:14 [PATCH 0/8] xen/arm: Add xentrace support Julien Grall
2018-11-06 19:14 ` [PATCH 1/8] xen/page_alloc: Move get_pg_owner()/put_pg_owner() from x86 to common code Julien Grall
2018-11-07 9:28 ` Jan Beulich
2018-11-09 18:06 ` Julien Grall
2018-11-06 19:14 ` [PATCH 2/8] xen/arm: p2m: Introduce p2m_get_page_from_gfn Julien Grall
2018-11-15 13:31 ` Andrii Anisov
2018-11-15 13:35 ` Andrii Anisov [this message]
2018-11-15 15:22 ` Julien Grall
2018-12-20 11:20 ` Andrii Anisov
2018-11-06 19:14 ` [PATCH 3/8] xen/arm: Rename p2m_map_foreign to p2m_map_foreign_rw Julien Grall
2018-11-15 11:42 ` Andrii Anisov
2018-11-15 12:07 ` Julien Grall
2018-11-06 19:14 ` [PATCH 4/8] xen/arm: Add support for read-only foreign mappings Julien Grall
2018-11-15 11:33 ` Andrii Anisov
2018-11-15 11:40 ` Julien Grall
2018-11-15 12:02 ` Andrii Anisov
2018-11-15 12:09 ` Julien Grall
2018-11-15 13:19 ` Andrii Anisov
2018-11-15 15:05 ` Julien Grall
2018-11-15 18:44 ` Stefano Stabellini
2018-11-15 19:06 ` Julien Grall
2018-11-15 19:48 ` Stefano Stabellini
2018-11-15 20:20 ` Julien Grall
2018-11-16 9:05 ` Andrii Anisov
2018-11-16 8:37 ` Andrii Anisov
2018-11-20 15:27 ` Andrii Anisov
2018-12-20 11:21 ` Andrii Anisov
2018-11-06 19:14 ` [PATCH 5/8] xen/arm: Allow a privileged domain to map foreign page from DOMID_XEN Julien Grall
2018-11-15 13:45 ` Andrii Anisov
2018-11-06 19:14 ` [PATCH 6/8] xen/arm: Initialize trace buffer Julien Grall
2018-11-15 13:49 ` Andrii Anisov
2018-11-06 19:14 ` [PATCH 7/8] xenalyze: Build for Both ARM and x86 Platforms Julien Grall
2018-11-07 13:04 ` Wei Liu
2018-11-06 19:14 ` [PATCH 8/8] xen: Swich parameter in get_page_from_gfn to use typesafe gfn Julien Grall
2018-11-06 20:11 ` Andrew Cooper
2018-11-07 8:57 ` Paul Durrant
2018-11-07 13:08 ` Andrew Cooper
2018-11-07 13:08 ` Julien Grall
2018-11-07 9:24 ` Paul Durrant
2018-11-07 13:05 ` Julien Grall
2018-11-12 16:49 ` Andrii Anisov
2018-11-12 16:52 ` Julien Grall
2018-11-12 16:58 ` Andrii Anisov
2018-11-12 17:09 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC1WxdipyzheoV21ftr7KgAgb4iPTA_4tHD3++Qv2KE8EO7npA@mail.gmail.com \
--to=andrii.anisov@gmail.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).