From: Christopher Clark <christopher.w.clark@gmail.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Doug Goldstein <cardoe@cardoe.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] build: remove tboot make targets
Date: Mon, 20 Aug 2018 11:50:25 -0700 [thread overview]
Message-ID: <CACMJ4Ga5-cHEsVJ63cXY0fwjOMu+9KiwPjxF3SwR13a60ugb3A@mail.gmail.com> (raw)
In-Reply-To: <20180820083837.5lujxzua2f34sdlj@citrix.com>
On Mon, Aug 20, 2018 at 1:38 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> On Sat, Aug 18, 2018 at 09:22:05PM -0500, Doug Goldstein wrote:
>> The tboot targets are woefully out of date. These should really be
>> retired because setting up tboot is more complex than the build process
>> for it.
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Code reviewed and standard (non-tboot related) build tested with the
patch applied: looks good.
No references to any of the following remain in the tree afterwards:
* TBOOT_TARFILE
* TBOOT_BASE_URL
* build-tboot, install-tboot, dist-tboot, clean-tboot, distclean-tboot
* download_tboot
The README section about tboot, just above the chunk removed, contains
a stale URL for the tboot hg repository, which has apparently now
moved to:
http://hg.code.sf.net/p/tboot/code
I don't use uninstall (ever) but since Doug's patch touches it, I just
tested it with this applied. Uninstall failed, but it's not a fault of
this patch:
| make[6]: Entering directory './git/tools/tests/x86_emulator'
| make[6]: *** No rule to make target 'uninstall'. Stop.
| make[6]: Leaving directory './git/tools/tests/x86_emulator'
|
| make[6]: *** No rule to make target 'uninstall'. Stop.
| make[6]: Leaving directory '/./git/tools/tests/x86_emulator'
| ./git/tools/tests/../../tools/Rules.mk:249: recipe for target
'subdir-uninstall-x86_emulator' failed
| make[5]: *** [subdir-uninstall-x86_emulator] Error 2
| make[5]: Leaving directory './git/tools/tests'
|
| ./git/tools/tests/../../tools/Rules.mk:249: recipe for target
'subdir-uninstall-x86_emulator' failed
so I've just posted a patch that fixes this and another defect in the
Linux hotplug uninstall logic to make it actually remove what it
installed.
Reviewed-by: Christopher Clark <christopher.clark6@baesystems.com>
Christopher
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-08-20 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 2:22 [PATCH] build: remove tboot make targets Doug Goldstein
2018-08-20 8:33 ` Jan Beulich
2018-08-27 16:23 ` Doug Goldstein
2018-08-28 1:56 ` Wei, Gang
2018-08-28 6:05 ` Jan Beulich
2018-08-20 8:38 ` Wei Liu
2018-08-20 18:50 ` Christopher Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACMJ4Ga5-cHEsVJ63cXY0fwjOMu+9KiwPjxF3SwR13a60ugb3A@mail.gmail.com \
--to=christopher.w.clark@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).