From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 01/27 v10] xen/arm: vpl011: Define common ring buffer helper functions in console.h
Date: Sat, 23 Sep 2017 20:39:50 +0530 [thread overview]
Message-ID: <CACtJ1JRyf43wUHn4wZP_SaP8mbx4bg9AfMayY6FkgpfHT85W1g@mail.gmail.com> (raw)
In-Reply-To: <bdf377a3-2dee-f184-5268-b0a10d08255f@arm.com>
Hi,
On 23 September 2017 at 18:55, Julien Grall <julien.grall@arm.com> wrote:
> Hi,
>
> On 09/22/2017 11:44 PM, Stefano Stabellini wrote:
>>
>> Adding Jan
>>
>> On Fri, 22 Sep 2017, Bhupinder Thakur wrote:
>>>
>>> DEFINE_XEN_FLEX_RING(xencons) defines common helper functions such as
>>> xencons_queued() to tell the current size of the ring buffer,
>>> xencons_mask() to mask off the index, which are useful helper functions.
>>> pl011 emulation code will use these helper functions.
>>>
>>> io/console.h includes io/ring.h which defines DEFINE_XEN_FLEX_RING.
>>>
>>> In console/daemon/io.c, string.h had to be included before io/console.h
>>> because ring.h uses string functions.
>>>
>>> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>> Acked-by: Wei Liu <wei.liu2@citrix.com>
>>> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>
>>
>> Unfortunately this patch breaks the build on x86.
>
>
> I am a bit surprised that this breaks only build on x86. I was expecting the
> header checks to be done on all the architecture ... hmmm... looking at the
> Makefile, the checks is only done when building natively. I guess you are
> cross-compiling?
>
> It might be interesting to look at getting headers check in cross-compile
> environment given that this is the main way to build the hypervisor today.
>
Yes I am doing cross-compilation.
>> The reason is that
>> DEFINE_XEN_FLEX_RING requires C99, and the current header checks in
>> xen/include/Makefile use ANSI C.
>
>
> I was not able to spot why DEFINE_XEN_FLEX_RING would require C99. Can you
> detail it?
This macro expands to generate inline functions, which I believe
require C99 to compile.
Regards,
Bhupinder
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-23 15:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:22 [PATCH 00/27 v10] SBSA UART emulation support in Xen Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 01/27 v10] xen/arm: vpl011: Define common ring buffer helper functions in console.h Bhupinder Thakur
2017-09-22 22:44 ` Stefano Stabellini
2017-09-23 13:25 ` Julien Grall
2017-09-23 15:09 ` Bhupinder Thakur [this message]
2017-09-25 7:51 ` Jan Beulich
2017-09-25 7:49 ` Jan Beulich
2017-09-25 23:08 ` Bhupinder Thakur
2017-09-26 7:15 ` Jan Beulich
2017-09-26 8:16 ` Bhupinder Thakur
2017-09-26 11:41 ` Jan Beulich
2017-09-22 8:23 ` [PATCH 02/27 v10] xen/arm: vpl011: Add SBSA UART emulation in Xen Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 03/27 v10] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 04/27 v10] xen/arm: vpl011: Add support for vuart in libxl Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 05/27 v10] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 06/27 v10] xen/arm: vpl011: Add a new domctl API to initialize vpl011 Bhupinder Thakur
2017-09-22 8:28 ` Jan Beulich
2017-09-22 21:46 ` Stefano Stabellini
2017-09-25 8:38 ` Wei Liu
2017-09-22 8:23 ` [PATCH 07/27 v10] xen/arm: vpl011: Add a new vuart node in the xenstore Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 08/27 v10] xen/arm: vpl011: Modify xenconsole to define and use a new console structure Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 09/27 v10] xen/arm: vpl011: Rename the console structure field conspath to xspath Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 10/27 v10] xen/arm: vpl011: Modify xenconsole functions to take console structure as input Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 11/27 v10] xen/arm: vpl011: Add a new console_init function in xenconsole Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 12/27 v10] xen/arm: vpl011: Add a new buffer_available " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 13/27 v10] xen/arm: vpl011: Add a new maybe_add_console_evtchn_fd " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 14/27 v10] xen/arm: vpl011: Add a new maybe_add_console_tty_fd " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 15/27 v10] xen/arm: vpl011: Add a new console_evtchn_unmask " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 16/27 v10] xen/arm: vpl011: Add a new handle_console_ring " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 17/27 v10] xen/arm: vpl011: Add a new handle_console_tty " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 18/27 v10] xen/arm: vpl011: Add a new console_cleanup " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 19/27 v10] xen/arm: vpl011: Add a new console_open_log " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 20/27 v10] xen/arm: vpl011: Add a new console_close_evtchn " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 21/27 v10] xen/arm: vpl011: Add support for multiple consoles " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 22/27 v10] xen/arm: vpl011: Add support for vuart console " Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 23/27 v10] xen/arm: vpl011: Add a new vuart console type to xenconsole client Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 24/27 v10] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 25/27 v10] xen/arm: vpl011: Update documentation for vuart console support Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 26/27 v10] xen/arm: vpl011: Fix the slow early console SBSA UART output Bhupinder Thakur
2017-09-22 8:23 ` [PATCH 27/27 v10] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt Bhupinder Thakur
2017-09-26 14:38 ` Dave Martin
2017-09-26 15:50 ` Julien Grall
2017-09-26 16:09 ` Dave Martin
2017-10-11 7:58 ` Bhupinder Thakur
2017-10-11 10:08 ` Dave Martin
2017-10-11 13:51 ` Bhupinder Thakur
2017-10-11 19:18 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACtJ1JRyf43wUHn4wZP_SaP8mbx4bg9AfMayY6FkgpfHT85W1g@mail.gmail.com \
--to=bhupinder.thakur@linaro.org \
--cc=JBeulich@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).