From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Grytsov Subject: Re: [PATCH v3 04/11] libxl: add generic function to add device Date: Fri, 7 Jul 2017 12:49:10 +0300 Message-ID: References: <1498557807-10810-1-git-send-email-al1img@gmail.com> <1498557807-10810-5-git-send-email-al1img@gmail.com> <20170706155105.n5kp76wd266xjgic@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTPsv-0002yu-V5 for xen-devel@lists.xenproject.org; Fri, 07 Jul 2017 09:49:14 +0000 Received: by mail-it0-f65.google.com with SMTP id 188so4546079itx.0 for ; Fri, 07 Jul 2017 02:49:12 -0700 (PDT) In-Reply-To: <20170706155105.n5kp76wd266xjgic@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: xen-devel@lists.xenproject.org, Ian Jackson , Oleksandr Grytsov List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBKdWwgNiwgMjAxNyBhdCA2OjUxIFBNLCBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXgu Y29tPiB3cm90ZToKPiBPbiBUdWUsIEp1biAyNywgMjAxNyBhdCAwMTowMzoyMFBNICswMzAwLCBP bGVrc2FuZHIgR3J5dHNvdiB3cm90ZToKPj4gRnJvbTogT2xla3NhbmRyIEdyeXRzb3YgPG9sZWtz YW5kcl9ncnl0c292QGVwYW0uY29tPgo+Pgo+PiBBZGQgbGlieGxfX2RldmljZV9hZGQgZnVuY3Rp by4KPj4gQWxtb3N0IGFsbCBkZXZpY2VzIGhhdmUgc2ltaWxhciBsaWJ4bF9fZGV2aWNlX3h4eHhf YWRkIGZ1bmN0aW9uLgo+PiBUaGlzIGdlbmVyaWMgZnVuY3Rpb24gaW1wbGVtZW50cyBzYW1lIGZ1 bmN0aW9uYWxpdHkgYnV0Cj4+IHVzaW5nIHRoZSBkZXZpY2UgaGFuZGxpbmcgZnJhbWV3b3JrLiBU aGUgZGV2aWNlIHNwZWNpZmljCj4+IHBhcnQgdGhpcyBpcyBzZXR0aW5nIHhlbiBzdG9yZSBjb25m aWd1cmF0aW9uLiBUaGlzIHBhcnQKPj4gaXMgbW92ZWQgdG8gc2V0X3hlbnN0b3JlX2NvbmZpZyBj YWxsYmFjayBvZiB0aGUgZGV2aWNlIGZyYW1ld29yay4KPj4KPj4gU2lnbmVkLW9mZi1ieTogT2xl a3NhbmRyIEdyeXRzb3YgPG9sZWtzYW5kcl9ncnl0c292QGVwYW0uY29tPgo+IFsuLi5dCj4+ICsK Pj4gK3ZvaWQgbGlieGxfX2RldmljZV9hZGQobGlieGxfX2VnYyAqZWdjLCB1aW50MzJfdCBkb21p ZCwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGxpYnhsX2RldmljZV90 eXBlICpkdCwgdm9pZCAqdHlwZSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX2Fv X2RldmljZSAqYW9kZXYpCj4+ICt7Cj4+ICsgICAgU1RBVEVfQU9fR0MoYW9kZXYtPmFvKTsKPj4g KyAgICBsaWJ4bF9fZGV2aWNlICpkZXZpY2U7Cj4+ICsgICAgaW50IHJjOwo+PiArCj4+ICsgICAg cmMgPSBkdC0+c2V0X2RlZmF1bHQoZ2MsIGRvbWlkLCB0eXBlKTsKPj4gKyAgICBpZiAocmMpIGdv dG8gb3V0Owo+PiArCj4+ICsgICAgR0NORVcoZGV2aWNlKTsKPj4gKyAgICByYyA9IGR0LT50b19k ZXZpY2UoZ2MsIGRvbWlkLCB0eXBlLCBkZXZpY2UpOwo+PiArICAgIGlmICggcmMgIT0gMCApIGdv dG8gb3V0Owo+PiArCj4+ICsgICAgcmMgPSBsaWJ4bF9fZGV2aWNlX2V4aXN0cyhnYywgWEJUX05V TEwsIGRldmljZSk7Cj4+ICsgICAgaWYgKHJjIDwgMCkgZ290byBvdXQ7Cj4+ICsgICAgaWYgKHJj ID09IDEpIHsgICAgICAgICAgICAgIC8qIGFscmVhZHkgZXhpc3RzIGluIHhlbnN0b3JlICovCj4+ ICsgICAgICAgIExPR0QoRVJST1IsIGRvbWlkLCAiZGV2aWNlIGFscmVhZHkgZXhpc3RzIGluIHhl bnN0b3JlIik7Cj4+ICsgICAgICAgIGFvZGV2LT5hY3Rpb24gPSBMSUJYTF9fREVWSUNFX0FDVElP Tl9BREQ7IC8qIGZvciBlcnJvciBtZXNzYWdlICovCj4+ICsgICAgICAgIHJjID0gRVJST1JfREVW SUNFX0VYSVNUUzsKPj4gKyAgICAgICAgZ290byBvdXQ7Cj4+ICsgICAgfQo+PiArCj4+ICsgICAg aWYgKGFvZGV2LT51cGRhdGVfanNvbikgewo+PiArICAgICAgICByYyA9IGRldmljZV9hZGRfZG9t YWluX2NvbmZpZyhnYywgZG9taWQsIGR0LCB0eXBlKTsKPj4gKyAgICAgICAgaWYgKHJjKSBnb3Rv IG91dDsKPj4gKyAgICB9Cj4+ICsKPj4gKyAgICBpZiAoZHQtPnNldF94ZW5zdG9yZV9jb25maWcp IHsKPj4gKyAgICAgICAgcmMgPSBkdC0+c2V0X3hlbnN0b3JlX2NvbmZpZyhnYywgZG9taWQsIHR5 cGUpOwo+PiArICAgICAgICBpZiAocmMpIGdvdG8gb3V0Owo+PiArICAgIH0KPj4gKwo+Cj4gVGhp cyBoYXMgY2hhbmdlZCB0aGUgbG9ja2luZyBoaWVyYXJjaHkgd2UgZGVmaW5lIGluIGxpYnhsX2lu dGVybmFsLmguCj4gU2VlIGxpYnhsX2ludGVybmFsLmg6TDI1OTIuCj4KPiBFaXRoZXIgeW91IG5l ZWQgdG8gcHJlc2VydmUgdGhlIGhpZXJhcmNoeSBvciB5b3UgbmVlZCB0byBwcm92ZSB0aGUKPiBj b3JyZWN0bmVzcyBvZiB0aGUgbmV3IGFwcHJvYWNoLiBUaGUgZm9ybWVyIGlzIHByb2JhYmx5IGVh c2llci4KCkFjdHVhbGx5IG15IHRoZSBmaXJzdCBwYXRjaCBwcm9iYWJseSB3YXMgZG9uZSBvbiB0 aGUgb2xkIGNvZGViYXNlCndoaWNoIGRvZXNuJ3QgaGF2ZSBsb2NraW5nIGluIGFkZCBmdW5jdGlv bi4gU28gbmV3IGFwcHJvYWNoIGlzCmRlZmluaXRlbHkgd3JvbmcgYW5kIEkgd2lsbCB1c2UgZm9y bWVyIG9uZS4KCi0tIApCZXN0IFJlZ2FyZHMsCk9sZWtzYW5kciBHcnl0c292LgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRl dmVsCg==