From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lengyel, Tamas" <tlengyel@novetta.com>
Subject: Re: [PATCH v3 09/13] x86/altp2m: alternate p2m memory
	events.
Date: Wed, 1 Jul 2015 14:29:55 -0400
Message-ID: <CAD33N+5KMbD+cvwc8k1aemyruWMH31ezsZXG8F_Q458myqTb4A@mail.gmail.com>
References: <1435774177-6345-1-git-send-email-edmund.h.white@intel.com>
	<1435774177-6345-10-git-send-email-edmund.h.white@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3572344990432391229=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1435774177-6345-10-git-send-email-edmund.h.white@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ed White <edmund.h.white@intel.com>
Cc: Ravi Sahita <ravi.sahita@intel.com>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

--===============3572344990432391229==
Content-Type: multipart/alternative; boundary=f46d043be02493ae800519d48358

--f46d043be02493ae800519d48358
Content-Type: text/plain; charset=ISO-8859-1

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c

> index 58d4951..576b28d 100644
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1514,6 +1514,13 @@ void p2m_mem_access_emulate_check(struct vcpu *v,
>      }
>  }
>
> +void p2m_altp2m_check(struct vcpu *v, const vm_event_response_t *rsp)
> +{
> +    if ( (rsp->flags & VM_EVENT_FLAG_ALTERNATE_P2M) &&
>

Please keep the check for (rsp->flags & VM_EVENT_FLAG_ALTERNATE_P2M) in
common/vm_event.c. With that you also only have to pass the altp2m_idx here.


> +         altp2m_active(v->domain) )
> +        p2m_switch_vcpu_altp2m_by_id(v, rsp->altp2m_idx);
> +}
> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> index 120a78a..57095d8 100644
> --- a/xen/common/vm_event.c
> +++ b/xen/common/vm_event.c
> @@ -399,6 +399,9 @@ void vm_event_resume(struct domain *d, struct
> vm_event_domain *ved)
>
>          };
>
> +        /* Check for altp2m switch */
> +        p2m_altp2m_check(v, &rsp);
>

See my comment above.

Thanks,
Tamas

--f46d043be02493ae800519d48358
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c=
<br><div class=3D"gmail_extra"><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
index 58d4951..576b28d 100644<br>
--- a/xen/arch/x86/mm/p2m.c<br>
+++ b/xen/arch/x86/mm/p2m.c<br>
@@ -1514,6 +1514,13 @@ void p2m_mem_access_emulate_check(struct vcpu *v,<br=
>
=A0 =A0 =A0}<br>
=A0}<br>
<br>
+void p2m_altp2m_check(struct vcpu *v, const vm_event_response_t *rsp)<br>
+{<br>
+=A0 =A0 if ( (rsp-&gt;flags &amp; VM_EVENT_FLAG_ALTERNATE_P2M) &amp;&amp;<=
br>
</blockquote><div><br></div><div>Please keep the check for (rsp-&gt;flags &=
amp; VM_EVENT_FLAG_ALTERNATE_P2M) in common/vm_event.c. With that you also =
only have to pass the altp2m_idx here.<br></div><div>=A0</div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex">+=A0 =A0 =A0 =A0 =A0altp2m_active(v-&g=
t;domain) )<br>
+=A0 =A0 =A0 =A0 p2m_switch_vcpu_altp2m_by_id(v, rsp-&gt;altp2m_idx);<br>
+}<br>
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c<br>
index 120a78a..57095d8 100644<br>
--- a/xen/common/vm_event.c<br>
+++ b/xen/common/vm_event.c<br>
@@ -399,6 +399,9 @@ void vm_event_resume(struct domain *d, struct vm_event_=
domain *ved)<br>
<br>
=A0 =A0 =A0 =A0 =A0};<br>
<br>
+=A0 =A0 =A0 =A0 /* Check for altp2m switch */<br>
+=A0 =A0 =A0 =A0 p2m_altp2m_check(v, &amp;rsp);<br></blockquote><div><br></=
div><div>See my comment above.<br><br></div><div>Thanks,<br></div><div>Tama=
s <br></div></div></div></div>

--f46d043be02493ae800519d48358--


--===============3572344990432391229==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3572344990432391229==--