From: Matthew Daley <mattd@bugfuzz.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Liu Jinsong <jinsong.liu@intel.com>,
Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>,
Xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Xiantao Zhang <xiantao.zhang@intel.com>
Subject: Re: [PATCH] xen: remove duplicate #includes
Date: Fri, 6 Dec 2013 01:34:36 +1300 [thread overview]
Message-ID: <CAD3CaneHY1cBOdQoRwhKz7DOchUCVzavJjHh3VbRPbk-QPyB6A@mail.gmail.com> (raw)
In-Reply-To: <52A05C51.8070301@eu.citrix.com>
On Thu, Dec 5, 2013 at 11:58 PM, George Dunlap
<george.dunlap@eu.citrix.com> wrote:
> On 12/05/2013 06:10 AM, Matthew Daley wrote:
>>
>> Signed-off-by: Matthew Daley <mattd@bugfuzz.com>
>
>
> Is this actually causing any problems at the moment?
No, it's just cleanup.
>
> Although it's pretty unlikely, there is a very small chance that this could
> cause a build breakage somewhere down the line; so if the "cost" of the
> redundant includes is just a few extra lines and a few extra file opens
> during compile, I'm inclined to say this should wait until 4.5.
I agree that it can wait until 4.5; I'll repost it then. Thanks!
- Matthew
next prev parent reply other threads:[~2013-12-05 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 6:10 [PATCH] xen: remove duplicate #includes Matthew Daley
2013-12-05 10:58 ` George Dunlap
2013-12-05 12:34 ` Matthew Daley [this message]
2014-03-12 13:25 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD3CaneHY1cBOdQoRwhKz7DOchUCVzavJjHh3VbRPbk-QPyB6A@mail.gmail.com \
--to=mattd@bugfuzz.com \
--cc=boris.ostrovsky@oracle.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=jinsong.liu@intel.com \
--cc=stefano.stabellini@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).