Re: [PATCH RFC 1/7] xen: Relocate mem_access and mem_event into common.

[Andres Lagar Cavilla <andres@lagarcavilla.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2242 bytes --]

On Fri, Aug 22, 2014 at 2:30 AM, Tamas K Lengyel <tamas.lengyel@zentific.com
> wrote:

> In preparation to add support for ARM LPAE mem_event, relocate mem_access
> and mem_event into common Xen code. This patch makes no functional changes
> to the X86 side, for ARM mem_event and mem_access functions are just
> placeholder stubs.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@zentific.com>
>
Big patch and assuming code motion LGTM. Couple of observations though.

Snip...


> -        req->flags |= MEM_EVENT_FLAG_FOREIGN;
> -        ASSERT( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) );
>
Take the opportunity to downgrade the aggressiveness of this at some point
in this series. (I'd prefer to keep code motion patches as purely code
motion).

A faulty tool stack can brick a debug hypervisor. Unpleasant while dev/test.

Snip ...

>
> +++ b/xen/common/mem_access.c
> @@ -0,0 +1,137 @@
>
> +/******************************************************************************
> + * mem_access.c
> + *
> + * Memory access support.
> + *
> + * Copyright (c) 2011 Virtuata, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
> USA
> + */
> +
> +
> +#include <xen/sched.h>
> +#include <xen/guest_access.h>
> +#include <xen/hypercall.h>
> +#include <asm/p2m.h>
> +#include <public/memory.h>
> +#include <xen/mem_event.h>
> +#include <xsm/xsm.h>
> +
> +#ifdef CONFIG_X86
>

Presumably this [will later be|should be] changed to consider CONFIG_ARM?

Many more like that one below with the same comment.

Thanks
Andres

>
> --
> 2.0.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 3382 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel