From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
Jean Guyader <jean.guyader@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Hypercall continuation cancelation in compat mode for XENMEM_get/set_pod_target.
Date: Fri, 11 Nov 2011 08:54:55 +0000 [thread overview]
Message-ID: <CAE2935F.2481A%keir.xen@gmail.com> (raw)
In-Reply-To: <4EBCED1A02000078000605BB@nat28.tlf.novell.com>
On 11/11/2011 08:38, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 10.11.11 at 18:17, Jean Guyader <jean.guyader@eu.citrix.com> wrote:
>
>> If copy_to_guest failed in the compat code after a continuation as been
>> done in the native code we need to cancel it so we won't reexecute the
>> hypercall but return from the hypercall with the appropriate error.
>>
>> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> (But I'd like to be certain that Keir also took a look at this before
> committing, not the least because this also should go into 4.1-testing.)
Looks okay to me.
Acked-by: Keir Fraser <keir@xen.org>
>> ---
>> xen/arch/x86/domain.c | 18 ++++++++++++++++++
>> xen/arch/x86/x86_64/compat/mm.c | 4 ++++
>> xen/include/xen/sched.h | 1 +
>> 3 files changed, 23 insertions(+), 0 deletions(-)
>
>
>
next prev parent reply other threads:[~2011-11-11 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 17:17 [PATCH] Hypercall continuation cancelation in compat mode for XENMEM_get/set_pod_target Jean Guyader
2011-11-11 8:38 ` Jan Beulich
2011-11-11 8:54 ` Keir Fraser [this message]
2011-11-17 6:01 ` Jean Guyader
2011-11-17 8:02 ` Jan Beulich
2011-11-17 9:15 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2935F.2481A%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=jean.guyader@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).