From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Re: [PATCH] SeaBIOS/Xen: Compute the low RAM memory size in the BDA according to the e820 Date: Mon, 14 Nov 2011 13:23:41 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="B_3404121826_77154596" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kevin O'Connor , Julian Pidancet Cc: xen-devel@lists.xensource.com, seabios@seabios.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3404121826_77154596 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit On 14/11/2011 08:53, "Keir Fraser" wrote: > On 14/11/2011 03:36, "Kevin O'Connor" wrote: > >> On Xen, the PCI init code isn't used, so assuming this struct doesn't >> need to live in real "ram", I think it could live just about anywhere >> past the end of ram. Even with pciinit.c, addresses over 0xfc00000 >> (with the exception of a few bytes for hpet, apic, ioapic, and bios >> image) could be used. > > I suggest we stick it at FC000000, and shift hvmloader's mem_alloc() > starting address up by one page to FC001000. The acpi build code will have > to manually mem_hole_populate_ram() that one page before writing to it. This > can then be documented in hvmloader/config.h which contains a description > of, and defines for, the system memory map. This is by far the easiest > solution to this problem; manually crafting an SSDT is a right pain in the > arse, whereas this is maybe a 5-line patch. Like the attached patch (untested), which is a bit larger than anticipated, but actually allows code to be net deleted. :-) -- Keir > -- Keir > >> -Kevin >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > > --B_3404121826_77154596 Content-type: application/octet-stream; name="00-relocate-acpi-info" Content-disposition: attachment; filename="00-relocate-acpi-info" Content-transfer-encoding: base64 ZGlmZiAtciAwODQ0YjE3ZGY3YTkgdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL2FjcGkvYnVp bGQuYwotLS0gYS90b29scy9maXJtd2FyZS9odm1sb2FkZXIvYWNwaS9idWlsZC5jCUZyaSBO b3YgMTEgMTg6MTQ6MzUgMjAxMSArMDAwMAorKysgYi90b29scy9maXJtd2FyZS9odm1sb2Fk ZXIvYWNwaS9idWlsZC5jCU1vbiBOb3YgMTQgMTM6MjA6MjYgMjAxMSArMDAwMApAQCAtMjc2 LDcgKzI3Niw3IEBAIHN0YXRpYyBpbnQgY29uc3RydWN0X3NlY29uZGFyeV90YWJsZXModW4K IAogdm9pZCBhY3BpX2J1aWxkX3RhYmxlcyhzdHJ1Y3QgYWNwaV9jb25maWcgKmNvbmZpZywg dW5zaWduZWQgaW50IHBoeXNpY2FsKQogewotICAgIHN0cnVjdCBhY3BpX2luZm8gKmFjcGlf aW5mbyA9IChzdHJ1Y3QgYWNwaV9pbmZvICopQUNQSV9JTkZPX1BIWVNJQ0FMX0FERFJFU1M7 CisgICAgc3RydWN0IGFjcGlfaW5mbyAqYWNwaV9pbmZvOwogICAgIHN0cnVjdCBhY3BpXzIw X3JzZHAgKnJzZHA7CiAgICAgc3RydWN0IGFjcGlfMjBfcnNkdCAqcnNkdDsKICAgICBzdHJ1 Y3QgYWNwaV8yMF94c2R0ICp4c2R0OwpAQCAtMjg3LDYgKzI4Nyw5IEBAIHZvaWQgYWNwaV9i dWlsZF90YWJsZXMoc3RydWN0IGFjcGlfY29uZmkKICAgICB1bnNpZ25lZCBsb25nICAgICAg ICBzZWNvbmRhcnlfdGFibGVzWzE2XTsKICAgICBpbnQgICAgICAgICAgICAgICAgICBucl9z ZWNvbmRhcmllcywgaTsKIAorICAgIC8qIEFsbG9jYXRlIGFuZCBpbml0aWFsaXNlIHRoZSBh Y3BpIGluZm8gYXJlYS4gKi8KKyAgICBtZW1faG9sZV9wb3B1bGF0ZV9yYW0oQUNQSV9JTkZP X1BIWVNJQ0FMX0FERFJFU1MgPj4gUEFHRV9TSElGVCwgMSk7CisgICAgYWNwaV9pbmZvID0g KHN0cnVjdCBhY3BpX2luZm8gKilBQ1BJX0lORk9fUEhZU0lDQUxfQUREUkVTUzsKICAgICBt ZW1zZXQoYWNwaV9pbmZvLCAwLCBzaXplb2YoKmFjcGlfaW5mbykpOwogCiAgICAgLyoKZGlm ZiAtciAwODQ0YjE3ZGY3YTkgdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL2FjcGkvZHNkdC5h c2wKLS0tIGEvdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL2FjcGkvZHNkdC5hc2wJRnJpIE5v diAxMSAxODoxNDozNSAyMDExICswMDAwCisrKyBiL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRl ci9hY3BpL2RzZHQuYXNsCU1vbiBOb3YgMTQgMTM6MjA6MjYgMjAxMSArMDAwMApAQCAtNjEs OCArNjEsOCBAQCBEZWZpbml0aW9uQmxvY2sgKCJEU0RULmFtbCIsICJEU0RUIiwgMiwgCiAK ICAgICBTY29wZSAoXF9TQikKICAgICB7Ci0gICAgICAgLyogQUNQSV9JTkZPX1BIWVNJQ0FM X0FERFJFU1MgPT0gMHg5RjAwMCAqLwotICAgICAgIE9wZXJhdGlvblJlZ2lvbihCSU9TLCBT eXN0ZW1NZW1vcnksIDB4OUYwMDAsIDI0KQorICAgICAgIC8qIEFDUElfSU5GT19QSFlTSUNB TF9BRERSRVNTID09IDB4RkMwMDAwMDAgKi8KKyAgICAgICBPcGVyYXRpb25SZWdpb24oQklP UywgU3lzdGVtTWVtb3J5LCAweEZDMDAwMDAwLCAyNCkKICAgICAgICBGaWVsZChCSU9TLCBC eXRlQWNjLCBOb0xvY2ssIFByZXNlcnZlKSB7CiAgICAgICAgICAgIFVBUjEsIDEsCiAgICAg ICAgICAgIFVBUjIsIDEsCmRpZmYgLXIgMDg0NGIxN2RmN2E5IHRvb2xzL2Zpcm13YXJlL2h2 bWxvYWRlci9jb25maWcuaAotLS0gYS90b29scy9maXJtd2FyZS9odm1sb2FkZXIvY29uZmln LmgJRnJpIE5vdiAxMSAxODoxNDozNSAyMDExICswMDAwCisrKyBiL3Rvb2xzL2Zpcm13YXJl L2h2bWxvYWRlci9jb25maWcuaAlNb24gTm92IDE0IDEzOjIwOjI2IDIwMTEgKzAwMDAKQEAg LTU0LDE4ICs1NCwxNyBAQCBleHRlcm4gc3RydWN0IGJpb3NfY29uZmlnIHNlYWJpb3NfY29u ZmlnCiAjZGVmaW5lIFBDSV9NRU1fRU5EICAgICAgICAgMHhmYzAwMDAwMAogZXh0ZXJuIHVu c2lnbmVkIGxvbmcgcGNpX21lbV9zdGFydCwgcGNpX21lbV9lbmQ7CiAKLS8qIFJlc2VydmVk IGZvciBzcGVjaWFsIEJJT1MgbWFwcGluZ3MsIGV0Yy4gKi8KLSNkZWZpbmUgUkVTRVJWRURf TUVNQkFTRSAgICAweGZjMDAwMDAwCiAKIC8qIE1lbW9yeSBtYXAuICovCiAjZGVmaW5lIFND UkFUQ0hfUEhZU0lDQUxfQUREUkVTUyAgICAgIDB4MDAwMTAwMDAKICNkZWZpbmUgSFlQRVJD QUxMX1BIWVNJQ0FMX0FERFJFU1MgICAgMHgwMDA4MDAwMAotI2RlZmluZSBBQ1BJX0lORk9f UEhZU0lDQUxfQUREUkVTUyAgICAweDAwMDlGMDAwCiAjZGVmaW5lIFZHQUJJT1NfUEhZU0lD QUxfQUREUkVTUyAgICAgIDB4MDAwQzAwMDAKICNkZWZpbmUgSFZNTE9BREVSX1BIWVNJQ0FM X0FERFJFU1MgICAgMHgwMDEwMDAwMAotCi0jZGVmaW5lIEFDUElfSU5GT19TSVpFICAgICAg ICAgICAgICAgICAgICAgMHhDMDAKLSNkZWZpbmUgQUNQSV9JTkZPX1BIWVNJQ0FMX0VORCAo QUNQSV9JTkZPX1BIWVNJQ0FMX0FERFJFU1MgKyBBQ1BJX0lORk9fU0laRSkKKy8qIFNwZWNp YWwgQklPUyBtYXBwaW5ncywgZXRjLiBhcmUgYWxsb2NhdGVkIGZyb20gaGVyZSB1cHdhcmRz Li4uICovCisjZGVmaW5lIFJFU0VSVkVEX01FTUJBU0UgICAgICAgICAgICAgIDB4RkMwMDAw MDAKKy8qIE5CLiBBQ1BJX0lORk9fUEhZU0lDQUxfQUREUkVTUyAqTVVTVCogbWF0Y2ggZGVm aW5pdGlvbiBpbiBhY3BpL2RzZHQuYXNsISAqLworI2RlZmluZSBBQ1BJX0lORk9fUEhZU0lD QUxfQUREUkVTUyAgICAweEZDMDAwMDAwCisjZGVmaW5lIFJFU0VSVkVEX01FTU9SWV9EWU5B TUlDICAgICAgIDB4RkMwMDEwMDAKIAogZXh0ZXJuIHVuc2lnbmVkIGxvbmcgc2NyYXRjaF9z dGFydDsKIApkaWZmIC1yIDA4NDRiMTdkZjdhOSB0b29scy9maXJtd2FyZS9odm1sb2FkZXIv ZTgyMC5jCi0tLSBhL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci9lODIwLmMJRnJpIE5vdiAx MSAxODoxNDozNSAyMDExICswMDAwCisrKyBiL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci9l ODIwLmMJTW9uIE5vdiAxNCAxMzoyMDoyNiAyMDExICswMDAwCkBAIC04MSw1NSArODEsMjQg QEAgaW50IGJ1aWxkX2U4MjBfdGFibGUoc3RydWN0IGU4MjBlbnRyeSAqZQogICAgIC8qIExv d21lbSBtdXN0IGJlIGF0IGxlYXN0IDUxMksgdG8ga2VlcCBXaW5kb3dzIGhhcHB5KSAqLwog ICAgIEFTU0VSVCAoIGxvd21lbV9yZXNlcnZlZF9iYXNlID4gNTEyPDwxMCApOwogCi0gICAg LyoKLSAgICAgKiBMb3dtZW0gcmVzZXJ2YXRpb24gbXVzdCBlaXRoZXIgY292ZXIgdGhlIEFD UEkgaW5mbyByZWdpb24KLSAgICAgKiBlbnRpcmVseSBvciBub3QgYXQgYWxsLiBTaXR0aW5n IGhhbGYgd2F5IHRocm91Z2ggc3VnZ2VzdHMKLSAgICAgKiBzb21ldGhpbmcgZnVubnkgaXMg Z29pbmcgb24uCi0gICAgICovCi0gICAgQVNTRVJUICggbG93bWVtX3Jlc2VydmVkX2Jhc2Ug PCBBQ1BJX0lORk9fUEhZU0lDQUxfQUREUkVTUyB8fAotICAgICAgICAgICAgIGxvd21lbV9y ZXNlcnZlZF9iYXNlID4gQUNQSV9JTkZPX1BIWVNJQ0FMX0VORCApOwotCiAgICAgQVNTRVJU ICggYmlvc19pbWFnZV9iYXNlIDwgMHgxMDAwMDAgKTsKIAotICAgIGlmICggbG93bWVtX3Jl c2VydmVkX2Jhc2UgPCBBQ1BJX0lORk9fUEhZU0lDQUxfQUREUkVTUyApCisgICAgLyoKKyAg ICAgKiAweDAtbG93bWVtX3Jlc2VydmVkX2Jhc2U6IE9yZGluYXJ5IFJBTS4KKyAgICAgKi8K KyAgICBlODIwW25yXS5hZGRyID0gMHgwMDAwMDsKKyAgICBlODIwW25yXS5zaXplID0gbG93 bWVtX3Jlc2VydmVkX2Jhc2U7CisgICAgZTgyMFtucl0udHlwZSA9IEU4MjBfUkFNOworICAg IG5yKys7CisKKyAgICAvKiBsb3dtZW1fcmVzZXJ2ZWRfYmFzZS0weEEwMDAwOiByZXNlcnZl ZCBieSBCSU9TIGltcGxlbWVudGF0aW9uLiAqLworICAgIGlmICggbG93bWVtX3Jlc2VydmVk X2Jhc2UgPCAweEEwMDAwICkKICAgICB7Ci0gICAgICAgIC8qCi0gICAgICAgICAqIDB4MC1s b3dtZW1fcmVzZXJ2ZWRfYmFzZTogT3JkaW5hcnkgUkFNLgotICAgICAgICAgKi8KLSAgICAg ICAgZTgyMFtucl0uYWRkciA9IDB4MDAwMDA7Ci0gICAgICAgIGU4MjBbbnJdLnNpemUgPSBs b3dtZW1fcmVzZXJ2ZWRfYmFzZTsKLSAgICAgICAgZTgyMFtucl0udHlwZSA9IEU4MjBfUkFN OwotICAgICAgICBucisrOwotICAgIH0KLSAgICBlbHNlCi0gICAgewotICAgICAgICAvKiAw eDAtQUNQSV9JTkZPOiBPcmRpbmFyeSBSQU0uICovCi0gICAgICAgIGU4MjBbbnJdLmFkZHIg PSAweDAwMDAwOwotICAgICAgICBlODIwW25yXS5zaXplID0gQUNQSV9JTkZPX1BIWVNJQ0FM X0FERFJFU1M7Ci0gICAgICAgIGU4MjBbbnJdLnR5cGUgPSBFODIwX1JBTTsKLSAgICAgICAg bnIrKzsKLQotICAgICAgICAvKiBBQ1BJIElORk86IFJlc2VydmVkLiAqLwotICAgICAgICBl ODIwW25yXS5hZGRyID0gQUNQSV9JTkZPX1BIWVNJQ0FMX0FERFJFU1M7Ci0gICAgICAgIGU4 MjBbbnJdLnNpemUgPSBBQ1BJX0lORk9fU0laRTsKKyAgICAgICAgLyogUmVzZXJ2ZWQgZm9y IGludGVybmFsIHVzZS4gKi8KKyAgICAgICAgZTgyMFtucl0uYWRkciA9IGxvd21lbV9yZXNl cnZlZF9iYXNlOworICAgICAgICBlODIwW25yXS5zaXplID0gMHhBMDAwMC1sb3dtZW1fcmVz ZXJ2ZWRfYmFzZTsKICAgICAgICAgZTgyMFtucl0udHlwZSA9IEU4MjBfUkVTRVJWRUQ7CiAg ICAgICAgIG5yKys7Ci0KLSAgICAgICAgLyogQUNQSV9JTkZPLWxvd21lbV9yZXNlcnZlZF9i YXNlOiBPcmRpbmFyeSBSQU0uICovCi0gICAgICAgIGU4MjBbbnJdLmFkZHIgPSBBQ1BJX0lO Rk9fUEhZU0lDQUxfRU5EOwotICAgICAgICBlODIwW25yXS5zaXplID0gbG93bWVtX3Jlc2Vy dmVkX2Jhc2UgLSBBQ1BJX0lORk9fUEhZU0lDQUxfRU5EOwotICAgICAgICBlODIwW25yXS50 eXBlID0gRTgyMF9SQU07Ci0gICAgICAgIG5yKys7Ci0gICAgfQotCi0gICAgLyogbG93bWVt X3Jlc2VydmVkX2Jhc2UtMHhhMDAwMDA6IHJlc2VydmVkIGJ5IEJJT1MgaW1wbGVtZW50YXRp b24uICovCi0gICAgaWYgKCBsb3dtZW1fcmVzZXJ2ZWRfYmFzZSA8IDB4QTAwMDAgKQotICAg IHsKLSAgICAgICAgICAgIC8qIFJlc2VydmVkIGZvciBpbnRlcm5hbCB1c2UuICovCi0gICAg ICAgICAgICBlODIwW25yXS5hZGRyID0gbG93bWVtX3Jlc2VydmVkX2Jhc2U7Ci0gICAgICAg ICAgICBlODIwW25yXS5zaXplID0gMHhBMDAwMC1sb3dtZW1fcmVzZXJ2ZWRfYmFzZTsKLSAg ICAgICAgICAgIGU4MjBbbnJdLnR5cGUgPSBFODIwX1JFU0VSVkVEOwotICAgICAgICAgICAg bnIrKzsKICAgICB9CiAKICAgICAvKgpkaWZmIC1yIDA4NDRiMTdkZjdhOSB0b29scy9maXJt d2FyZS9odm1sb2FkZXIvcm9tYmlvcy5jCi0tLSBhL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRl ci9yb21iaW9zLmMJRnJpIE5vdiAxMSAxODoxNDozNSAyMDExICswMDAwCisrKyBiL3Rvb2xz L2Zpcm13YXJlL2h2bWxvYWRlci9yb21iaW9zLmMJTW9uIE5vdiAxNCAxMzoyMDoyNiAyMDEx ICswMDAwCkBAIC00Nyw3ICs0Nyw2IEBAIHN0YXRpYyB2b2lkIHJvbWJpb3Nfc2V0dXBfZTgy MCh2b2lkKQogewogICAgIC8qCiAgICAgICogMHg5RTAwMC0weDA5RjAwMDogU3RhY2suCi0g ICAgICogMHg5RjAwMC0weDA5QzAwMDogQUNQSSBpbmZvLgogICAgICAqIDB4OUZDMDAtMHgw QTAwMDA6IEV4dGVuZGVkIEJJT1MgRGF0YSBBcmVhIChFQkRBKS4KICAgICAgKiAuLi4KICAg ICAgKiAweEUwMDAwLTB4MEYwMDAwOiBQQy1zcGVjaWZpYyBhcmVhLiBXZSBwbGFjZSB2YXJp b3VzIHRhYmxlcyBoZXJlLgpkaWZmIC1yIDA4NDRiMTdkZjdhOSB0b29scy9maXJtd2FyZS9o dm1sb2FkZXIvdXRpbC5jCi0tLSBhL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci91dGlsLmMJ RnJpIE5vdiAxMSAxODoxNDozNSAyMDExICswMDAwCisrKyBiL3Rvb2xzL2Zpcm13YXJlL2h2 bWxvYWRlci91dGlsLmMJTW9uIE5vdiAxNCAxMzoyMDoyNiAyMDExICswMDAwCkBAIC0zNDMs NyArMzQzLDcgQEAgdm9pZCBtZW1faG9sZV9wb3B1bGF0ZV9yYW0oeGVuX3Bmbl90IG1mbgog ICAgIH0KIH0KIAotc3RhdGljIHVpbnQzMl90IHJlc2VydmUgPSBSRVNFUlZFRF9NRU1CQVNF IC0gMTsKK3N0YXRpYyB1aW50MzJfdCByZXNlcnZlID0gUkVTRVJWRURfTUVNT1JZX0RZTkFN SUMgLSAxOwogCiB4ZW5fcGZuX3QgbWVtX2hvbGVfYWxsb2ModWludDMyX3QgbnJfbWZucykK IHsK --B_3404121826_77154596 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --B_3404121826_77154596--