From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: x86 emulator and new isa additions Date: Tue, 15 Nov 2011 15:48:35 +0000 Message-ID: References: <4EC27CDC02000078000611A1@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4EC27CDC02000078000611A1@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 15/11/2011 13:53, "Jan Beulich" wrote: >> So, properly, I think the fact we already have a cpuid callback ought to be >> sufficient to implement all the cpu_has functionality that the emulator >> could want, perhaps hidden behind some helper/abstraction functions/macros. > > Which may make it necessary to add cpuid callbacks to all emulator > users (seems like only hvm currently has one). But it indeed looks like > the right route to go, so I'll look into doing so. Yes, probably. The CPUID emulation backend is similar across both PV and HVM, so there shouldn't be much per-user shimming to be done. -- Keir