From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] x86/vioapic: clear remote IRR when switching RTE to edge triggered mode
Date: Mon, 21 Nov 2011 08:25:07 +0000 [thread overview]
Message-ID: <CAEFBB63.2546D%keir.xen@gmail.com> (raw)
In-Reply-To: <4ECA17310200007800062083@nat28.tlf.novell.com>
On 21/11/2011 08:17, "Jan Beulich" <JBeulich@suse.com> wrote:
> Xen itself (as much as Linux) relies on this behavior, so it should
> also emulate it properly. Not doing so reportedly gets in the way of
> kexec inside a HVM guest.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/hvm/vioapic.c
> +++ b/xen/arch/x86/hvm/vioapic.c
> @@ -154,8 +154,9 @@ static void vioapic_write_redirent(
> {
> vlapic_adjust_i8259_target(d);
> }
> - else if ( (ent.fields.trig_mode == VIOAPIC_LEVEL_TRIG) &&
> - !ent.fields.mask &&
> + else if ( ent.fields.trig_mode == VIOAPIC_EDGE_TRIG )
> + pent->fields.remote_irr = 0;
> + else if ( !ent.fields.mask &&
> !ent.fields.remote_irr &&
> hvm_irq->gsi_assert_count[idx] )
> {
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-11-21 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 8:17 [PATCH] x86/vioapic: clear remote IRR when switching RTE to edge triggered mode Jan Beulich
2011-11-21 8:25 ` Keir Fraser [this message]
2011-11-21 8:30 ` Jan Beulich
2011-11-21 8:39 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEFBB63.2546D%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).