From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH v2] x86: re-inject emulated level pirqs in PV on HVM guests if still asserted Date: Mon, 21 Nov 2011 11:54:32 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini , Jan Beulich Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 21/11/2011 11:06, "Stefano Stabellini" wrote: > On Mon, 21 Nov 2011, Jan Beulich wrote: >>>>> On 18.11.11 at 12:13, Stefano Stabellini >>>>> >> wrote: >>> This patch is a backport of CS 24007 for xen-4.1-testing. >>> >>> PV on HVM guests can loose level interrupts coming from emulated >>> devices if they have been remapped onto event channels. The reason is >>> that we are missing the code to inject a pirq again in the guest when >>> the guest EOIs it, if it corresponds to an emulated level interrupt >>> and the interrupt is still asserted. >>> >>> Fix this issue and also return error when the guest tries to get the >>> irq_status of a non-existing pirq. >>> >>> >>> Changes in v2: >>> >>> - move the spinlock afterward to cover the new code only. >> >> This, as expected, doesn't hang anymore with kernels making use of >> the PIRQ EOI map. > > Thanks for testing! > Keir, are you happy with the patch? Yes, I applied it already. -- Keir