From mboxrd@z Thu Jan 1 00:00:00 1970 From: Meng Xu Subject: Re: [PATCH RFC v1 2/4] xl for rt scheduler Date: Fri, 11 Jul 2014 12:25:10 -0400 Message-ID: References: <1405054198-29106-1-git-send-email-mengxu@cis.upenn.edu> <1405054198-29106-3-git-send-email-mengxu@cis.upenn.edu> <20140711110206.GD12584@zion.uk.xensource.com> <1405091227.29306.463.camel@Solace> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2348026416539853349==" Return-path: In-Reply-To: <1405091227.29306.463.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Wei Liu , Ian Campbell , Sisu Xi , Stefano Stabellini , George Dunlap , Ian Jackson , "xen-devel@lists.xen.org" , Meng Xu , Chong Li , Dagaen Golomb List-Id: xen-devel@lists.xenproject.org --===============2348026416539853349== Content-Type: multipart/alternative; boundary=047d7b2e4206a25e8804fded626a --047d7b2e4206a25e8804fded626a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Dario, 2014-07-11 11:07 GMT-04:00 Dario Faggioli : > On ven, 2014-07-11 at 10:59 -0400, Meng Xu wrote: > > > > > + libxl_domain_sched_params_init(&scinfo); > > > + rc =3D sched_domain_get(LIBXL_SCHEDULER_RT, domid, > > &scinfo); > > > + if (rc) > > > + return rc; > > > + > > > =E2=80=8BThank you very much for pasting the rules here! I really appre= ciate > > it. However, I didn't quite get why it violate the libxl type paradigm > > and how I should correct it. (Sorry. :-()=E2=80=8B > > > < up, regardless of whether operations on this object succeeded or > failed>> > > While, above, you're exiting, if rc is true, without calling dispose. > > It depens a lot on the function, but what you usually do, is grouping > the calls to the various dispose under a label (typically 'out:') and > goto there to exit. > > Look around, both in xl and libxl, you'll find plenty of examples of > that. > =E2=80=8BNow I got it. Thank you very much! I will modify it. :-) Best regards, Meng ----------- Meng Xu PhD Student in Computer and Information Science University of Pennsylvania --047d7b2e4206a25e8804fded626a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi = Dario,

2014-= 07-11 11:07 GMT-04:00 Dario Faggioli <dario.faggioli@citrix.com>:
On ven, 2014-07-11 at 10:59 = -0400, Meng Xu wrote:


> =C2=A0 =C2=A0 =C2=A0 =C2=A0 > + =C2=A0 =C2=A0libxl_domain_sched_par= ams_init(&scinfo);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 > + =C2=A0 =C2=A0rc =3D sched_domain_ge= t(LIBXL_SCHEDULER_RT, domid,
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 &scinfo);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 > + =C2=A0 =C2=A0if (rc)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 > + =C2=A0 =C2=A0 =C2=A0 =C2=A0return r= c;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 > +

> =E2=80=8BThank you very much for pasting the rul= es here! I really appreciate
> it. However, I didn't quite get why it violate the libxl type para= digm
> and how I should correct it. (Sorry. :-()=E2=80=8B
>
<<The user must always calls "dispose" exactly once a= fterwards, to clean
up, regardless of whether operations on this object succeeded or
failed>>

While, above, you're exiting, if rc is true, without calling dispose.
It depens a lot on the function, but what you usually do, is grouping
the calls to the various dispose under a label (typically 'out:') a= nd
goto there to exit.

Look around, both in xl and libxl, you'll find plenty of examples of that.

=E2=80=8BNow I got it. Thank you very much! I will modify = it. :-)

Best regards,
<= br>
Meng
<= /div>


-----------
Meng Xu
PhD Student in Comp= uter and Information Science
University of Pennsylvania
--047d7b2e4206a25e8804fded626a-- --===============2348026416539853349== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2348026416539853349==--