Re: [PATCH v3 4/7] libxl: vNUMA supporting interface

[Elena Ufimtseva <ufimtseva@gmail.com>]

On Thu, Nov 21, 2013 at 4:59 AM, Li Yechen <lccycc123@gmail.com> wrote:
> Hi Elena and Dario,
>> +    /* Determine the best nodes to fit vNUMA nodes */
>> +    /* TODO: change algorithm. The current just fits the nodes
>> +     * Will be nice to have them also sorted by size
>> +     * If no p-node found, will be set to NUMA_NO_NODE
>> +     */
>> +    claim = calloc(info->nr_vnodes, sizeof(*claim));
>> +    if (claim == NULL)
>> +        return rc;
>> +
>> +    libxl_for_each_set_bit(n, info->nodemap)
>> +    {
>> +        for (i = 0; i < info->nr_vnodes; i++)
>> +        {
>> +            if (((claim[n] + (mems[i] << 20)) <= ninfo[n].free) &&
>> +                 /*vnode was not set yet */
>> +                 (info->vnode_to_pnode[i] == VNUMA_NO_NODE ) )
>> +            {
>> +                info->vnode_to_pnode[i] = n;
>> +                claim[n] += (mems[i] << 20);
>> +            }
>> +        }
>> +    }
>> +
>
> So in the initial part, each vnode is set to EXACTLY ONE pnode, right?

Hi Yechen

Yes, one node or VNUMA_NO_NODE (any node);

>
>
> --
>
> Yechen Li
>
> Team of System Virtualization and Cloud Computing
> School of Electronic Engineering  and Computer Science,
> Peking University, China
>
> Nothing is impossible because impossible itself  says: " I'm possible "
> lccycc From PKU



-- 
Elena