From mboxrd@z Thu Jan  1 00:00:00 1970
From: Elena Ufimtseva <ufimtseva@gmail.com>
Subject: Re: [PATCH v3 4/7] libxl: vNUMA supporting interface
Date: Tue, 26 Nov 2013 17:14:48 -0500
Message-ID: <CAEr7rXi_r2ErYLqd9vumjcagMNjFiNY-RKY_TEJobEkVMx3JbA@mail.gmail.com>
References: <1384806262-12532-1-git-send-email-ufimtseva@gmail.com>
	<1384806262-12532-5-git-send-email-ufimtseva@gmail.com>
	<1384886226.19880.182.camel@Abyss>
	<CAP5+zHSWWNRgePRhpbZsOmbAv1mvFAuTqo3ccBc5wga1Ex0Bcw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAP5+zHSWWNRgePRhpbZsOmbAv1mvFAuTqo3ccBc5wga1Ex0Bcw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Li Yechen <lccycc123@gmail.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Matt Wilson <msw@linux.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Nov 21, 2013 at 4:59 AM, Li Yechen <lccycc123@gmail.com> wrote:
> Hi Elena and Dario,
>> +    /* Determine the best nodes to fit vNUMA nodes */
>> +    /* TODO: change algorithm. The current just fits the nodes
>> +     * Will be nice to have them also sorted by size
>> +     * If no p-node found, will be set to NUMA_NO_NODE
>> +     */
>> +    claim = calloc(info->nr_vnodes, sizeof(*claim));
>> +    if (claim == NULL)
>> +        return rc;
>> +
>> +    libxl_for_each_set_bit(n, info->nodemap)
>> +    {
>> +        for (i = 0; i < info->nr_vnodes; i++)
>> +        {
>> +            if (((claim[n] + (mems[i] << 20)) <= ninfo[n].free) &&
>> +                 /*vnode was not set yet */
>> +                 (info->vnode_to_pnode[i] == VNUMA_NO_NODE ) )
>> +            {
>> +                info->vnode_to_pnode[i] = n;
>> +                claim[n] += (mems[i] << 20);
>> +            }
>> +        }
>> +    }
>> +
>
> So in the initial part, each vnode is set to EXACTLY ONE pnode, right?

Hi Yechen

Yes, one node or VNUMA_NO_NODE (any node);

>
>
> --
>
> Yechen Li
>
> Team of System Virtualization and Cloud Computing
> School of Electronic Engineering  and Computer Science,
> Peking University, China
>
> Nothing is impossible because impossible itself  says: " I'm possible "
> lccycc From PKU



-- 
Elena