From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elena Ufimtseva Subject: Re: [PATCH RFC v2 1/2] linux/vnuma: vNUMA for PV domu guest Date: Wed, 18 Sep 2013 03:39:14 -0400 Message-ID: References: <1379406841-7441-1-git-send-email-ufimtseva@gmail.com> <1379406841-7441-2-git-send-email-ufimtseva@gmail.com> <5238657F.3040209@oracle.com> <1379489625.18543.30.camel@Abyss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379489625.18543.30.camel@Abyss> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Li Yechen , George Dunlap , "xen-devel@lists.xen.org" , Matt Wilson , Boris Ostrovsky , "anddavid.vrabel" List-Id: xen-devel@lists.xenproject.org On Wed, Sep 18, 2013 at 3:33 AM, Dario Faggioli wrote: > On mer, 2013-09-18 at 02:30 -0400, Elena Ufimtseva wrote: >> On Tue, Sep 17, 2013 at 10:21 AM, Boris Ostrovsky >> >> >> +int __init xen_numa_init(void) >> >> +{ > [snip] >> >> + setup_nr_node_ids(); >> >> + /* Setting the cpu, apicid to node */ >> >> + for_each_cpu(cpu, cpu_possible_mask) { >> >> + set_apicid_to_node(cpu, cpu_to_node[cpu]); >> >> + numa_set_node(cpu, cpu_to_node[cpu]); >> >> + __apicid_to_node[cpu] = cpu_to_node[cpu]; >> > >> > >> > Isn't this what set_apicid_to_node() above will do? >> >> Yes, exactly the same ) will fix. >> > I seem to recall that something strange was happening if we do not do > this in this way (i.e., calling the same stuff twice, or something like > that), isn't it so Elena? > I think its in the past as proper ordering made sense and that second call was removed :) > If it is, please, explain that in a comment. However, it may well be > possible that my recollection is wrong.. In which case, sorry for the > noise. > > Anyway, in general, and both for this series and for the Xen one, I > think the code could use a little bit more of commenting (along with the > breaking up in paragraphs, as many have already pointed out). > > I know, I know, too much comments is also bad... Actually, finding the > right balance between too few and too much is as much important as it is > difficult! :-P I see that ) I will learn. > > Dario > > -- > <> (Raistlin Majere) > ----------------------------------------------------------------- > Dario Faggioli, Ph.D, http://about.me/dario.faggioli > Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) > -- Elena