From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH for-4.5 v7 04/21] xen: Relocate set_access_required domctl into common Date: Thu, 18 Sep 2014 12:36:24 +0200 Message-ID: References: <1410987084-11899-1-git-send-email-tklengyel@sec.in.tum.de> <1410987084-11899-5-git-send-email-tklengyel@sec.in.tum.de> <541ABF710200007800036134@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3712596668383550106==" Return-path: In-Reply-To: <541ABF710200007800036134@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Campbell , Tim Deegan , Julien Grall , Ian Jackson , "xen-devel@lists.xen.org" , Stefano Stabellini , Andres Lagar-Cavilla , Daniel De Graaf , Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org --===============3712596668383550106== Content-Type: multipart/alternative; boundary=089e0149d2e869d4500503548eb9 --089e0149d2e869d4500503548eb9 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Sep 18, 2014 at 11:18 AM, Jan Beulich wrote: > >>> On 17.09.14 at 22:51, wrote: > > Signed-off-by: Tamas K Lengyel > > Acked-by: Jan Beulich > with one minor remark: > > > --- a/xen/include/asm-arm/p2m.h > > +++ b/xen/include/asm-arm/p2m.h > > @@ -198,6 +198,9 @@ int arch_grant_map_page_identity(struct domain *d, > unsigned long frame, > > bool_t writeable); > > int arch_grant_unmap_page_identity(struct domain *d, unsigned long > frame); > > > > +/* get host p2m table */ > > +#define p2m_get_hostp2m(d) (&((d)->arch.p2m)) > > There's a superfluous pair of parentheses here. > > Jan > Ack, I find it more readable to have &() when dereferencing a pointer within the parenthesis. Tamas --089e0149d2e869d4500503548eb9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable


On Thu, Sep 18, 2014 at 11:18 AM, Jan Beulich <JBeulich@suse.com&g= t; wrote:
>>= ;> On 17.09.14 at 22:51, <= tklengyel@sec.in.tum.de> wrote:
> Signed-off-by: Tamas K Lengyel <tklengyel@sec.in.tum.de>

Acked-by: Jan Beulich <jbeul= ich@suse.com>
with one minor remark:

> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -198,6 +198,9 @@ int arch_grant_map_page_identity(struct domain *d,= unsigned long frame,
>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= bool_t writeable);
>=A0 int arch_grant_unmap_page_identity(struct domain *d, unsigned long = frame);
>
> +/* get host p2m table */
> +#define p2m_get_hostp2m(d) (&((d)->arch.p2m))

There's a superfluous pair of parentheses here.

Jan

Ack, I find it more r= eadable to have &() when dereferencing a pointer within the parenthesis= .

Tamas

--089e0149d2e869d4500503548eb9-- --===============3712596668383550106== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3712596668383550106==--