From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH v5 13/17] xen/arm: Instruction prefetch
 abort (X) mem_event handling
Date: Fri, 12 Sep 2014 10:34:44 +0200
Message-ID: <CAErYnsjsYPHVRpc288_YN2mGK3LUXoaHzJDAaiUK-eG6D847tA@mail.gmail.com>
References: <1410355726-5599-1-git-send-email-tklengyel@sec.in.tum.de>
	<1410355726-5599-14-git-send-email-tklengyel@sec.in.tum.de>
	<541212B4.2070705@linaro.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8572498642805619813=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <541212B4.2070705@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jan Beulich <jbeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

--===============8572498642805619813==
Content-Type: multipart/alternative; boundary=001a11c3030835758e0502da2883

--001a11c3030835758e0502da2883
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Sep 11, 2014 at 11:23 PM, Julien Grall <julien.grall@linaro.org>
wrote:

> Hello Tamas,
>
> On 10/09/14 06:28, Tamas K Lengyel wrote:
>
>> +    default:
>> +        break;
>> +    }
>>
>
> I don't think the default: break; is useful here. I would drop it.
>
>
I seem to recall some compilers warning me in the past if there was no
default case (in a separate project), but that might just have been an
overly restrictive setting I had.

Tamas


>
> --
> Julien Grall
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

--001a11c3030835758e0502da2883
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Thu, Sep 11, 2014 at 11:23 PM, Julien Grall <span dir=3D"ltr">&lt;<a=
 href=3D"mailto:julien.grall@linaro.org" target=3D"_blank">julien.grall@lin=
aro.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D=
"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Tamas=
,<span class=3D""><br>
<br>
On 10/09/14 06:28, Tamas K Lengyel wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
+=A0 =A0 default:<br>
+=A0 =A0 =A0 =A0 break;<br>
+=A0 =A0 }<br>
</blockquote>
<br></span>
I don&#39;t think the default: break; is useful here. I would drop it.<span=
 class=3D"HOEnZb"><font color=3D"#888888"><br>
<br></font></span></blockquote><div><br></div><div>I seem to recall some co=
mpilers warning me in the past if there was no default case (in a separate =
project), but that might just have been an overly restrictive setting I had=
.<br><br></div><div>Tamas<br></div><div>=A0</div><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex"><span class=3D"HOEnZb"><font color=3D"#888888">
<br>
-- <br>
Julien Grall</font></span><div class=3D"HOEnZb"><div class=3D"h5"><br>
<br>
______________________________<u></u>_________________<br>
Xen-devel mailing list<br>
<a href=3D"mailto:Xen-devel@lists.xen.org" target=3D"_blank">Xen-devel@list=
s.xen.org</a><br>
<a href=3D"http://lists.xen.org/xen-devel" target=3D"_blank">http://lists.x=
en.org/xen-devel</a><br>
</div></div></blockquote></div><br></div></div>

--001a11c3030835758e0502da2883--


--===============8572498642805619813==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8572498642805619813==--