Re: [PATCH v2] libxl: support for "rtc_timeoffset" and "localtime"

[Lin Ming <mlin@ss.pku.edu.cn>]

On Mon, Mar 19, 2012 at 11:40 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Mon, 2012-03-19 at 15:31 +0000, Lin Ming wrote:
>> From 0614ad85fc5956d95d988b88689cc4967b4d8af8 Mon Sep 17 00:00:00 2001
>> From: Lin Ming <mlin@ss.pku.edu.cn>
>> Date: Sun, 18 Mar 2012 13:14:32 +0800
>> Subject: [PATCH] libxl: support for "rtc_timeoffset" and "localtime"
>>
>> Implement "rtc_timeoffset" and "localtime" options compatible as xm.
>>
>> rtc_timeoffset is the offset between host time and guest time.
>> localtime means to specify whether the emulted RTC appears as UTC or is
>> offset by the host.
>>
>> Signed-off-by: Lin Ming <mlin@ss.pku.edu.cn>
>
> Looks good to me, thanks!
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Although when you repost please can you fix the following:
>> [...]
>> @@ -767,6 +767,14 @@ Set mode for Virtual Timers XXX ??? should be an enum of particular
>>  values. See C<HVM_PARAM_TIMER_MODE> in
>>  F<xen/include/public/hvm/params.h>.
>
> The is the end of a sub section entitled "Unclassified HVM Specific
> Options". I think these new options belong in the "Guest Virtual Time
> Controls" subsection or perhaps "Miscellaneous Emulated Hardware".

OK, "Guest Virtual Time Controls" looks better to me.

Will move there.

>
> Ian.