From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lin Ming <mlin@ss.pku.edu.cn>
Subject: Re: [PATCH v2] libxl: support for "rtc_timeoffset" and
	"localtime"
Date: Mon, 19 Mar 2012 23:49:41 +0800
Message-ID: <CAF1ivSZ8SGqgYOYoLSFk_pvQZDTTKK4JErw3UPakfmd6XwG8DQ@mail.gmail.com>
References: <1332162123-3975-1-git-send-email-mlin@ss.pku.edu.cn>
	<1332163187.9223.69.camel@zakaz.uk.xensource.com>
	<1332171078.8074.11.camel@hp6530s>
	<1332171647.9223.106.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1332171647.9223.106.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Teck Choon Giam <giamteckchoon@gmail.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, Mar 19, 2012 at 11:40 PM, Ian Campbell <Ian.Campbell@citrix.com> wr=
ote:
> On Mon, 2012-03-19 at 15:31 +0000, Lin Ming wrote:
>> From 0614ad85fc5956d95d988b88689cc4967b4d8af8 Mon Sep 17 00:00:00 2001
>> From: Lin Ming <mlin@ss.pku.edu.cn>
>> Date: Sun, 18 Mar 2012 13:14:32 +0800
>> Subject: [PATCH] libxl: support for "rtc_timeoffset" and "localtime"
>>
>> Implement "rtc_timeoffset" and "localtime" options compatible as xm.
>>
>> rtc_timeoffset is the offset between host time and guest time.
>> localtime means to specify whether the emulted RTC appears as UTC or is
>> offset by the host.
>>
>> Signed-off-by: Lin Ming <mlin@ss.pku.edu.cn>
>
> Looks good to me, thanks!
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Although when you repost please can you fix the following:
>> [...]
>> @@ -767,6 +767,14 @@ Set mode for Virtual Timers XXX ??? should be an en=
um of particular
>> =A0values. See C<HVM_PARAM_TIMER_MODE> in
>> =A0F<xen/include/public/hvm/params.h>.
>
> The is the end of a sub section entitled "Unclassified HVM Specific
> Options". I think these new options belong in the "Guest Virtual Time
> Controls" subsection or perhaps "Miscellaneous Emulated Hardware".

OK, "Guest Virtual Time Controls" looks better to me.

Will move there.

>
> Ian.