From: Peter Maydell <peter.maydell@linaro.org>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>,
xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386
Date: Wed, 4 Apr 2012 16:40:34 +0100 [thread overview]
Message-ID: <CAFEAcA839S=YEXdL+TM1Wo7TWJRxZ1rxhLmf_HCb+Y3qukmi-g@mail.gmail.com> (raw)
In-Reply-To: <20348.26046.686582.18393@mariner.uk.xensource.com>
On 4 April 2012 16:16, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386"):
>> configure will generate incorrect CFLAGS which will lead to compile
>> errors due to unknown gcc options, iff CFLAGS was already in the
>> environment during configure invocation.
>
> Don't do that then.
>
> In general, CFLAGS is not a variable you can safely set in your
> environment when invoking a nonconsenting build system.
Yes. You probably wanted configure's --extra-cflags option.
However that doesn't mean the code in configure at the moment
is actually right...
Having looked at configure I'm pretty sure what we want here is
QEMU_CFLAGS="-march=i486 $QEMU_CFLAGS"
because we're only doing this for the benefit of a particular bit
of code in hw/vhost.c and so QEMU_CFLAGS is sufficient. Also this
brings it into line with other places where we add a -march flag,
which use QEMU_CFLAGS, not CFLAGS.
-- PMM
next prev parent reply other threads:[~2012-04-04 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 17:32 [PATCH v2] qemu/configure: fix CFLAGS handling for i386 Olaf Hering
2012-04-04 15:16 ` Ian Jackson
2012-04-04 15:40 ` Peter Maydell [this message]
2012-04-04 16:09 ` [Qemu-devel] " Peter Maydell
2012-04-05 7:28 ` [Xen-devel] " Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA839S=YEXdL+TM1Wo7TWJRxZ1rxhLmf_HCb+Y3qukmi-g@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=Ian.Jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).